ensure all tags are returned if no message is sent - closes #170

stephenlacy · Aug 9, 2017 · 951c0d7 · 951c0d7
1 parent 0accffa
commit 951c0d7
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/examples/gulpfile.js b/examples/gulpfile.js
@@ -166,6 +166,12 @@ gulp.task('tagsec', function() {
   });
 });
 
+gulp.task('tagall', function() {
+  git.tag(function(err, tags) {
+    console.log(tags);
+  });
+});
+
 gulp.task('push-tag', function() {
   git.push('origin', 'v1.1.1', function (err) {
     if (err) {

diff --git a/lib/tag.js b/lib/tag.js
@@ -17,7 +17,11 @@ module.exports = function (version, message, opt, cb) {
   }
   if (!cb || typeof cb !== 'function') cb = function () {};
   if (!opt) opt = {};
-  if (!message) opt.lightWeight = true; else message = escape([message]);
+  if (!message) {
+    opt.lightWeight = true;
+    message = '';
+  }
+  else message = escape([message]);
   if (!opt.cwd) opt.cwd = process.cwd();
   if (!opt.args) opt.args = ' ';
 

diff --git a/test/tag.js b/test/tag.js
@@ -33,4 +33,13 @@ module.exports = function(git) {
       });
     });
   });
+
+  it('should return all tags', function(done) {
+    git.tag(function(err, tags) {
+      should(tags).not.be.null();
+      should(tags[0]).not.be.null();
+      should(tags[0]).equal('0.5.1');
+      done();
+    });
+  });
 };