Skip to content

Commit

Permalink
refactor tests ^^ goodbye async
Browse files Browse the repository at this point in the history
  • Loading branch information
@rauchg
rauchg committed Apr 6, 2015
1 parent 36a8f5a commit 1d40652
Showing 1 changed file with 59 additions and 174 deletions.
233 changes: 59 additions & 174 deletions test/index.js
View file
Original file line number Diff line number Diff line change
@@ -1,198 +1,83 @@

var http = require('http').Server;
var io = require('socket.io');
var ioc = require('socket.io-client');
var expect = require('expect.js');
var async = require('async');
var redis = require('redis');
var redisAdapter = require('../');


function client(srv, nsp, opts){
if ('object' == typeof nsp) {
opts = nsp;
nsp = null;
}
var addr = srv.address();
if (!addr) {
addr = srv.listen().address();
}
var url = 'ws://' + addr.address + ':' + addr.port + (nsp || '');
return ioc(url, opts);
}
var redis = require('redis').createClient;
var adapter = require('../');

describe('socket.io-redis', function(){
describe('broadcast', function(){
beforeEach(function(done){
this.redisClients = [];
var self = this;

async.times(2, function(n, next){
var pub = redis.createClient();
var sub = redis.createClient(null, null, {detect_buffers: true});
var srv = http();
var sio = io(srv, {adapter: redisAdapter({pubClient: pub, subClient: sub})});
self.redisClients.push(pub, sub);

srv.listen(function(){
['/', '/nsp'].forEach(function(name){
sio.of(name).on('connection', function(socket){
socket.on('join', function(callback){
socket.join('room', callback);
});

socket.on('leave', function(callback){
socket.leave('room', callback);
});

socket.on('socket broadcast', function(data){
socket.broadcast.to('room').emit('broadcast', data);
});

socket.on('namespace broadcast', function(data){
sio.of('/nsp').in('room').emit('broadcast', data);
});

socket.on('request', function(data){
socket.emit('reply', data);
});
});
});

async.parallel([
function(callback){
async.times(2, function(n, next){
var socket = client(srv, '/nsp', {forceNew: true});
socket.on('connect', function(){
socket.emit('join', function(){
next(null, socket);
});
});
}, callback);
},
function(callback){
// a socket of the same namespace but not joined in the room.
var socket = client(srv, '/nsp', {forceNew: true});
socket.on('connect', function(){
socket.on('broadcast', function(){
throw new Error('Called unexpectedly: different room');
});
callback();
});
},
function(callback){
// a socket joined in a room but for a different namespace.
var socket = client(srv, {forceNew: true});
socket.on('connect', function(){
socket.on('broadcast', function(){
throw new Error('Called unexpectedly: different namespace');
});
socket.emit('join', function(){
callback();
});
});
}
], function(err, results){
next(err, results[0]);
});
it('broadcasts', function(done){
create(function(server1, client1){
create(function(server2, client2){
client1.on('woot', function(a, b){
expect(a).to.eql([]);
expect(b).to.eql({ a: 'b' });
done();
});
}, function(err, sockets){
self.sockets = sockets.reduce(function(a, b){ return a.concat(b); });
done(err);
});
});

afterEach(function(){
this.redisClients.forEach(function(client){
client.quit();
});
});

it('should broadcast from a socket', function(done){
async.each(this.sockets.slice(1), function(socket, next){
socket.on('broadcast', function(message){
expect(message).to.equal('hi');
next();
server2.on('connection', function(c2){
c2.broadcast.emit('woot', [], { a: 'b' });
});
}, done);

var socket = this.sockets[0];
socket.on('broadcast', function(){
throw new Error('Called unexpectedly: same socket');
});
socket.emit('socket broadcast', 'hi');
});
});

it('should broadcast from a namespace', function(done){
async.each(this.sockets, function(socket, next){
socket.on('broadcast', function(message){
expect(message).to.equal('hi');
next();
});
}, done);
it('broadcasts to rooms', function(done){
create(function(server1, client1){
create(function(server2, client2){
create(function(server3, client3){
server1.on('connection', function(c1){
c1.join('woot');
});

this.sockets[0].emit('namespace broadcast', 'hi');
});
server2.on('connection', function(c2){
// does not join, performs broadcast
c2.on('do broadcast', function(){
c2.broadcast.to('woot').emit('broadcast');
});
});

it('should reply to one client', function(done){
this.sockets.slice(1).forEach(function(socket){
socket.on('reply', function(message){
throw new Error('Called unexpectedly: other socket');
});
});
server3.on('connection', function(c3){
// does not join, signals broadcast
client2.emit('do broadcast');
});

this.sockets[0].on('reply', function(message){
expect(message).to.equal('hi');
done();
});
this.sockets[0].emit('request', 'hi');
});
client1.on('broadcast', function(){
setTimeout(done, 100);
});

it('should not send message for clients left the room', function(done){
var self = this;
client2.on('broadcast', function(){
throw new Error('Not in room');
});

async.each(this.sockets, function(socket, next){
socket.on('broadcast', function(message){
throw new Error('Called unexpectedly: client already left the room');
client3.on('broadcast', function(){
throw new Error('Not in room');
});
});
socket.emit('leave', next);
}, function (err) {
self.sockets[0].emit('namespace broadcast', 'hi');
done();
});
});
});

it('should unsubscribe from the channel if there are no more room members', function(done){
var self = this;

async.each(this.sockets, function(socket, next){
socket.emit('leave', next);
}, function (err) {
var pub = self.redisClients[0];
pub.pubsub('numsub', 'socket.io#/nsp#room#', function (err, subscriptions) {
expect(parseInt(subscriptions[1])).to.be(0);
done(err);
});
});
// create a pair of socket.io server+client
function create(nsp, fn){
var srv = http();
var sio = io(srv);
sio.adapter(adapter({
pubClient: redis(),
subClient: redis(null, null, { detect_buffers: true })
}));
srv.listen(function(err){
if (err) throw err; // abort tests
if ('function' == typeof nsp) {
fn = nsp;
nsp = '';
}
nsp = nsp || '/';
var addr = srv.address();
var url = 'http://localhost:' + addr.port + nsp;
fn(sio.of(nsp), ioc(url));
});
}

it('should unsubscribe from the channel if clients have disconnected', function(done){
var self = this;

setTimeout(function () {
async.each(self.sockets, function(socket, next){
socket.once('disconnect', next);
socket.disconnect();
}, function (err) {
setTimeout(function () {
var pub = self.redisClients[0];

pub.pubsub('numsub', 'socket.io#/nsp#room#', function (err, subscriptions) {
expect(parseInt(subscriptions[1])).to.be(0);
done(err);
});
}, 20);
});
}, 20);
});
});
});

0 comments on commit 1d40652

Please sign in to comment.