Comparing changes
Open a pull request
base repository: socketio/socket.io-client
base: 5529f34aafe31058879fd2302d4fca82b32cf4a5
head repository: socketio/socket.io-client
compare: b574be703945453f94ddb96c74b3b84f2ceda5bd
- 12 commits
- 18 files changed
- 3 contributors
Commits on Jan 28, 2021
-
In Socket.IO v2, the Socket `query` option was sent when connecting to a custom namespace (but not for the main namespace). This was fixed in Socket.IO v3 ([1]), so this line is now useless. [1]: https://socket.io/docs/v3/migrating-from-2-x-to-3-0/#Add-a-clear-distinction-between-the-Manager-query-option-and-the-Socket-query-option
Configuration menu - View commit details
-
Copy full SHA for 0a63a17 - Browse repository at this point
Copy the full SHA 0a63a17View commit details -
Configuration menu - View commit details
-
Copy full SHA for be81a2c - Browse repository at this point
Copy the full SHA be81a2cView commit details
Commits on Feb 2, 2021
-
fix(typings): fix the type of the "query" option (#1439)
Having type `Object` it was not possible to set values, e.g.: ```ts if (!this.socket.io.opts.query) { this.socket.io.opts.query = {}; } this.socket.io.opts.query.token = 'abc123'; ``` Results in error: > Element implicitly has an 'any' type because expression of type '"token"' can't be used to index type 'Object'.
Configuration menu - View commit details
-
Copy full SHA for f02ab3b - Browse repository at this point
Copy the full SHA f02ab3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 47f917a - Browse repository at this point
Copy the full SHA 47f917aView commit details -
fix: remove polyfill for process in the bundle
A polyfill for Node.js "process" was included in the final bundle. Reference: https://webpack.js.org/configuration/node/
Configuration menu - View commit details
-
Copy full SHA for 61afc5d - Browse repository at this point
Copy the full SHA 61afc5dView commit details
Commits on Feb 3, 2021
-
fix: include the path in the manager ID
Previously, the following code: ```js const socket1 = io({ path: "/test1" }); const socket2 = io({ path: "/test2" }); ``` would result in one single Manager, with the "/test2" path being silently ignored. Two distinct Manager instances will now be created. Related: #1225
Configuration menu - View commit details
-
Copy full SHA for 7a0c2b5 - Browse repository at this point
Copy the full SHA 7a0c2b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 311c5d1 - Browse repository at this point
Copy the full SHA 311c5d1View commit details
Commits on Feb 25, 2021
-
fix: restore support for web workers
A previous change ([1], included in 3.0.5) broke support for web workers, which threw "window is not defined" when importing the bundle in a web worker. Related: socketio/socket.io#3809 Reference: https://webpack.js.org/configuration/output/#outputglobalobject [1]: 8c08c5d
Configuration menu - View commit details
-
Copy full SHA for 13b32b3 - Browse repository at this point
Copy the full SHA 13b32b3View commit details
Commits on Feb 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 83a65be - Browse repository at this point
Copy the full SHA 83a65beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78ec5a6 - Browse repository at this point
Copy the full SHA 78ec5a6View commit details
Commits on Mar 12, 2021
-
fix(bundle): restore support for JS modules
This change is needed so the bundle can be used with: ``` <script type="module" src="xxxx/socket.io.js"></script> ``` Related: - socketio/socket.io#3828 - 13b32b3 - 8c08c5d Backported from master: 43613d1
Configuration menu - View commit details
-
Copy full SHA for afa7953 - Browse repository at this point
Copy the full SHA afa7953View commit details -
Configuration menu - View commit details
-
Copy full SHA for b574be7 - Browse repository at this point
Copy the full SHA b574be7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 5529f34aafe31058879fd2302d4fca82b32cf4a5...b574be703945453f94ddb96c74b3b84f2ceda5bd