Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-client
base: 5529f34aafe31058879fd2302d4fca82b32cf4a5
Choose a base ref
...
head repository: socketio/socket.io-client
compare: b574be703945453f94ddb96c74b3b84f2ceda5bd
Choose a head ref
  • 12 commits
  • 18 files changed
  • 3 contributors

Commits on Jan 28, 2021

  1. refactor: remove unused line

    In Socket.IO v2, the Socket `query` option was sent when connecting to
    a custom namespace (but not for the main namespace).
    
    This was fixed in Socket.IO v3 ([1]), so this line is now useless.
    
    [1]: https://socket.io/docs/v3/migrating-from-2-x-to-3-0/#Add-a-clear-distinction-between-the-Manager-query-option-and-the-Socket-query-option
    darrachequesne committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    0a63a17 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be81a2c View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. fix(typings): fix the type of the "query" option (#1439)

    Having type `Object` it was not possible to set values, e.g.:
    
    ```ts
    if (!this.socket.io.opts.query) {
      this.socket.io.opts.query = {};
    }
    this.socket.io.opts.query.token = 'abc123';
    ```
    
    Results in error:
    
    > Element implicitly has an 'any' type because expression of type '"token"' can't be used to index type 'Object'.
    MickL authored and darrachequesne committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    f02ab3b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    47f917a View commit details
    Browse the repository at this point in the history
  3. fix: remove polyfill for process in the bundle

    A polyfill for Node.js "process" was included in the final bundle.
    
    Reference: https://webpack.js.org/configuration/node/
    darrachequesne committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    61afc5d View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. fix: include the path in the manager ID

    Previously, the following code:
    
    ```js
    const socket1 = io({
      path: "/test1"
    });
    const socket2 = io({
      path: "/test2"
    });
    ```
    
    would result in one single Manager, with the "/test2" path being
    silently ignored.
    
    Two distinct Manager instances will now be created.
    
    Related: #1225
    darrachequesne committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    7a0c2b5 View commit details
    Browse the repository at this point in the history
  2. chore(release): 3.1.1

    darrachequesne committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    311c5d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. fix: restore support for web workers

    A previous change ([1], included in 3.0.5) broke support for web
    workers, which threw "window is not defined" when importing the bundle
    in a web worker.
    
    Related: socketio/socket.io#3809
    
    Reference: https://webpack.js.org/configuration/output/#outputglobalobject
    
    [1]: 8c08c5d
    darrachequesne committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    13b32b3 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Configuration menu
    Copy the full SHA
    83a65be View commit details
    Browse the repository at this point in the history
  2. chore(release): 3.1.2

    darrachequesne committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    78ec5a6 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. fix(bundle): restore support for JS modules

    This change is needed so the bundle can be used with:
    
    ```
    <script type="module" src="xxxx/socket.io.js"></script>
    ```
    
    Related:
    
    - socketio/socket.io#3828
    - 13b32b3
    - 8c08c5d
    
    Backported from master: 43613d1
    darrachequesne committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    afa7953 View commit details
    Browse the repository at this point in the history
  2. chore(release): 3.1.3

    darrachequesne committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    b574be7 View commit details
    Browse the repository at this point in the history