fix: prevent socket from reconnecting after middleware failure

Related: socketio/socket.io#4150
socketio · Nov 16, 2021 · d54d12c · d54d12c
1 parent ccf7998
commit d54d12c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/socket.ts b/lib/socket.ts
@@ -322,6 +322,7 @@ export class Socket<
         break;
 
       case PacketType.CONNECT_ERROR:
+        this.destroy();
         const err = new Error(packet.data.message);
         // @ts-ignore
         err.data = packet.data.data;

diff --git a/test/socket.ts b/test/socket.ts
@@ -214,6 +214,23 @@ describe("socket", function () {
     });
   });
 
+  it("should not try to reconnect after a middleware failure", (done) => {
+    const socket = io("/no", { forceNew: true, reconnectionDelay: 10 });
+
+    let count = 0;
+
+    socket.on("connect_error", () => {
+      count++;
+      // force reconnection
+      socket.io.engine.close();
+    });
+
+    setTimeout(() => {
+      expect(count).to.eql(1);
+      done();
+    }, 100);
+  });
+
   it("should throw on reserved event", () => {
     const socket = io("/no", { forceNew: true });