fix: correctly pass the options when using the Server constructor (#610)

Fixes #580
socketio · Dec 30, 2020 · cec2750 · cec2750
1 parent 04ea358
commit cec2750
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/engine.io.js b/lib/engine.io.js
@@ -26,7 +26,7 @@ exports = module.exports = function() {
   }
 
   // if first argument is not an http server, then just make a regular eio server
-  return new Server(arguments);
+  return new Server(...arguments);
 };
 
 /**

diff --git a/test/engine.io.js b/test/engine.io.js
@@ -25,6 +25,11 @@ describe("engine", () => {
       expect(engine).to.be.an(eio.Server);
       expect(engine.ws).to.be.ok();
     });
+
+    it("should pass options correctly to the Server", () => {
+      const engine = eio({ cors: true });
+      expect(engine.opts).to.have.property("cors", true);
+    });
   });
 
   describe("listen", () => {