[refactor] Add some checks to prevent usage of undefined properties (#…

…540)
socketio · Feb 18, 2018 · 8d0ce5f · 8d0ce5f
1 parent 1a685c0
commit 8d0ce5f
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/lib/server.js b/lib/server.js
@@ -266,11 +266,13 @@ function sendErrorMessage (req, res, code) {
   } else {
     headers['Access-Control-Allow-Origin'] = '*';
   }
-  res.writeHead(400, headers);
-  res.end(JSON.stringify({
-    code: code,
-    message: Server.errorMessages[code]
-  }));
+  if (res !== undefined) {
+    res.writeHead(400, headers);
+    res.end(JSON.stringify({
+      code: code,
+      message: Server.errorMessages[code]
+    }));
+  }
 }
 
 /**
@@ -379,7 +381,7 @@ Server.prototype.handleUpgrade = function (req, socket, upgradeHead) {
 Server.prototype.onWebSocket = function (req, socket) {
   socket.on('error', onUpgradeError);
 
-  if (!transports[req._query.transport].prototype.handlesUpgrades) {
+  if (transports[req._query.transport] !== undefined && !transports[req._query.transport].prototype.handlesUpgrades) {
     debug('transport doesnt handle upgraded requests');
     socket.close();
     return;