Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: snyk/cli
base: v1.848.0
Choose a base ref
...
head repository: snyk/cli
compare: v1.849.0
Choose a head ref
  • 18 commits
  • 24 files changed
  • 5 contributors

Commits on Jan 26, 2022

  1. chore: include eslint fixes in format script

    Jahed Ahmed committed Jan 26, 2022
    Copy the full SHA
    4810c21 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. chore(ci): merge release and pr pipelines

    In order to test our artifacts before a release, we can merge the two pipelines we currently have: PR (builds and runs tests) and Release (builds and releases).
    
    These are currently under the same "workflow" in CircleCI but are split based on a filter which checks if the branch is "master". By removing this filter, the pipelines can be merged. We'll keep the "master" filter as a prerequisite for release.
    
    We now also build once so we can see what was generated and test them. The release job only uploads files.
    
    Lerna is no longer needed as npm workspaces provides better support for this separated build, test, release workflow.
    
    The "should-release" approval step is temporary so that we can manually validate the new pipeline's artifacts are correct on master.
    Jahed Ahmed committed Feb 4, 2022
    Copy the full SHA
    521e22b View commit details
    Browse the repository at this point in the history
  2. chore(ci): run tests against cli release tarball

    To make sure we've built it correctly. Also removes the need to build the tarball twice.
    Jahed Ahmed committed Feb 4, 2022
    Copy the full SHA
    5de1822 View commit details
    Browse the repository at this point in the history
  3. chore(ci): validate npm tarball checksums

    Like we do with our various other artifacts to ensure they're not
    corrupt before release.
    
    I've also renamed the tarballs to remove the version so that they're
    less dynamic and easier to work with. The version is within the tarball,
    the filename isn't used for anything special.
    Jahed Ahmed committed Feb 4, 2022
    Copy the full SHA
    f9be810 View commit details
    Browse the repository at this point in the history
  4. chore(ci): move all artifacts into a single directory

    So that they're easier to keep track of.
    Jahed Ahmed committed Feb 4, 2022
    Copy the full SHA
    32399f0 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. docs: update contributing guide

    We often get questions on how to contribute to this repo. What versions to use, what the workflow is, etc. This PR updated our CONTRIBUTING guide to answer that.
    
    I've also left a notice for external contributors on how we prefer to handle external contributions.
    Jahed Ahmed committed Feb 7, 2022
    Copy the full SHA
    eb53a6b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2631 from snyk/docs/jan-contributing

    docs: update contributing guide
    Jahed Ahmed committed Feb 7, 2022
    Copy the full SHA
    f71979d View commit details
    Browse the repository at this point in the history
  3. chore(ci): run windows tests against snyk-win.exe

    This ensures our Windows builds are valid before release.
    
    I've removed `npm_version` from analytics as it's only relevant for
    OSS NPM scans rather than being "standard data".
    
    Also made general analytics test changes so that they're more flexible
    to different test environments.
    Jahed Ahmed committed Feb 7, 2022
    Copy the full SHA
    b6b1686 View commit details
    Browse the repository at this point in the history
  4. chore: Update filepath in codeowners after rename

    Ilianna Papastefanou committed Feb 7, 2022
    Copy the full SHA
    6b95bc2 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #2674 from snyk/chore/merge-pipelines

    chore(ci): merge release and pr pipelines
    Jahed Ahmed committed Feb 7, 2022
    Copy the full SHA
    de749b1 View commit details
    Browse the repository at this point in the history
  6. fix: Invalid JAR fingerprints for Maven projects

    Bumping snyk-docker-plugin to 4.34.5 which fixes invalid dep-graph in Maven
    projects causing issues with calculating a package's vulnerable paths
    pecodez committed Feb 7, 2022
    Copy the full SHA
    5f5caa8 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #2712 from snyk/chore/update-codeowners-iac

    Update filepath in codeowners after rename
    ipapast committed Feb 7, 2022
    Copy the full SHA
    402c91d View commit details
    Browse the repository at this point in the history
  8. Merge pull request #2733 from snyk/fix/invalid-dep-graph

    fix: Invalid JAR fingerprints for Maven projects
    pecodez committed Feb 7, 2022
    Copy the full SHA
    5983d15 View commit details
    Browse the repository at this point in the history
  9. Merge pull request #2666 from snyk/chore/test-win-exe

    chore(ci): run windows tests against snyk-win.exe
    Jahed Ahmed committed Feb 7, 2022
    Copy the full SHA
    0a1e56a View commit details
    Browse the repository at this point in the history
  10. chore(ci): npm publish needs ./ to know it's a tarball

    Jahed Ahmed committed Feb 7, 2022
    Copy the full SHA
    ce54666 View commit details
    Browse the repository at this point in the history
  11. chore(ci): remove commit type check for releases

    We now require manual approval for each release so that we have better control over new releases.
    Jahed Ahmed committed Feb 7, 2022
    Copy the full SHA
    fb4e959 View commit details
    Browse the repository at this point in the history
  12. chore(ci): fail releases not on master

    So that we don't accidently cause a release when modifying our pipelines.
    Jahed Ahmed committed Feb 7, 2022
    Copy the full SHA
    ec7c203 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #2742 from snyk/chore/remove-commit-check-for-release

    chore(ci): tidy up release job
    Jahed Ahmed committed Feb 7, 2022
    Copy the full SHA
    48ab12b View commit details
    Browse the repository at this point in the history