Navigation Menu

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: snyk/cli
base: v1.817.0
Choose a base ref
...
head repository: snyk/cli
compare: v1.818.0
Choose a head ref
  • 13 commits
  • 16 files changed
  • 3 contributors

Commits on Dec 31, 2021

  1. chore(ci): re-enable sdkman caching

    Jahed Ahmed committed Dec 31, 2021
    Copy the full SHA
    38e2be2 View commit details
    Browse the repository at this point in the history
  2. chore(ci): lock sdkman version

    SDKMAN's install process does not let us choose a version. This can cause our pipelines to break at any point if SDKMAN makes a breaking change.
    
    To reduce our dependence on SDKMAN's servers, I've vendored the install script so that it's more predictable. I've also cached the install so we don't need to keep pulling in the installation archive from their servers on every PR run.
    Jahed Ahmed committed Dec 31, 2021
    Copy the full SHA
    fcf2c30 View commit details
    Browse the repository at this point in the history
  3. chore(ci): reduce resource class

    These jobs utilise less than 50% of a large's resource. It's a waste. Go back to default (medium).
    Jahed Ahmed committed Dec 31, 2021
    Copy the full SHA
    4a5b22d View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Merge pull request #2505 from snyk/chore/sdkman-enable-cache-again

    chore(ci): re-enable sdkman caching
    Jahed Ahmed committed Jan 5, 2022
    Copy the full SHA
    cd766a1 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2506 from snyk/chore/reduce-resource-class

    chore(ci): reduce resource class
    Jahed Ahmed committed Jan 5, 2022
    Copy the full SHA
    a4c5a7a View commit details
    Browse the repository at this point in the history
  3. chore(ci): migrate to cimg images

    Jahed Ahmed committed Jan 5, 2022
    Copy the full SHA
    600d735 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2413 from snyk/chore/cimg

    chore(ci): migrate to cimg images
    Jahed Ahmed committed Jan 5, 2022
    Copy the full SHA
    d9494db View commit details
    Browse the repository at this point in the history
  5. fix: Remove scanResult from json output

    The scanResult object was added to the json output where
    it should only have been added to calculate the the
    dockerfile warning string.
    This change removes the scanResult from the json output
    as it was not supposed to be exposed.
    snaftaly committed Jan 5, 2022
    Copy the full SHA
    fcff339 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    5d29d7f View commit details
    Browse the repository at this point in the history
  7. refactor: Strip json result array after formatting

    This refactor is done to not have a special case for
    array vs single result when formatting the results
    for JSON output.
    Note: dataToSend will now take the jsonData after formatting
    rather than the data before formatting. Since the formatting
    only changes the vulnerbilities and removes the unwanted
    scanResult, and since the vulnerbilities are removed from
    dataToSend before it is used, this change will not affect the
    CLI bahvior except for removing the unwanted scanResult.
    snaftaly committed Jan 5, 2022
    Copy the full SHA
    8c93f31 View commit details
    Browse the repository at this point in the history
  8. refactor: Rename errorMappedResults to mappedResults

    Renaming the object as in IaC the logic does more than mapping
    the results.
    snaftaly committed Jan 5, 2022
    Copy the full SHA
    5805f4f View commit details
    Browse the repository at this point in the history
  9. refactor: Rename fixtures to align with variable name

    Rename test fixtures used in format-test-results to align
    with the variable name change.
    This is done in a separate commit so it's clearer in git
    history that the files were changed and then renamed rather
    than deleted and created new files.
    snaftaly committed Jan 5, 2022
    Copy the full SHA
    1949818 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Merge pull request #2502 from snyk/fix/remove-scan-results-from-json

    fix: Remove scanResult from json output [MAGMA-1280]
    snaftaly committed Jan 6, 2022
    Copy the full SHA
    9b7f9a5 View commit details
    Browse the repository at this point in the history