Merge pull request #1760 from snyk/feat/support-critical-in-sarif

feat: add critical severity support for sarif output format
snyk · Mar 29, 2021 · f14819f · f14819f
2 parents 9ed99f3 + 30fbd0e
commit f14819f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/cli/commands/test/open-source-sarif-output.ts b/src/cli/commands/test/open-source-sarif-output.ts
@@ -117,6 +117,7 @@ export function getResults(testResult): sarif.Result[] {
 
 export function getLevel(vuln: AnnotatedIssue) {
   switch (vuln.severity) {
+    case SEVERITY.CRITICAL:
     case SEVERITY.HIGH:
       return 'error';
     case SEVERITY.MEDIUM:

diff --git a/test/jest/unit/sarif.spec.ts b/test/jest/unit/sarif.spec.ts
@@ -11,6 +11,7 @@ describe('createSarifOutputForOpenSource', () => {
     expect(run.tool.driver.name).toEqual('Snyk Open Source');
     expect(run.tool.driver.rules).toHaveLength(1);
     expect(run.results).toHaveLength(1);
+    expect(run.results?.[0].level === 'error');
   });
 
   describe('replace lock-file to manifest-file', () => {
@@ -63,7 +64,7 @@ function getTestResult(testResultOverride = {}, vulnOverride = {}): TestResult {
         semver: {
           vulnerable: ['<6.12.3'],
         },
-        severity: SEVERITY.HIGH,
+        severity: SEVERITY.CRITICAL,
         title: 'Prototype Pollution',
         from: [
           'PROJECT_NAME@1.0.0',