fix: correct iac error import & add tests

snyk · Jul 28, 2020 · efbcf84 · efbcf84
1 parent 87151b8
commit efbcf84
Show file tree

Hide file tree

Showing 3 changed files with 49 additions and 2 deletions.
diff --git a/src/lib/snyk-test/index.js b/src/lib/snyk-test/index.js
@@ -7,7 +7,7 @@ const pm = require('../package-managers');
 const iacProjects = require('../iac/iac-projects');
 const {
   UnsupportedPackageManagerError,
-  NoSupportedIacFileError,
+  NotSupportedIacFileError,
 } = require('../errors');
 
 async function test(root, options, callback) {
@@ -58,7 +58,7 @@ function run(root, options) {
   if (options.iac) {
     const projectType = options.packageManager;
     if (!iacProjects.TEST_SUPPORTED_IAC_PROJECTS.includes(projectType)) {
-      throw new NoSupportedIacFileError(projectType);
+      throw new NotSupportedIacFileError(projectType);
     }
     return runTest(projectType, root, options);
   }

diff --git a/test/acceptance/cli-args.test.ts b/test/acceptance/cli-args.test.ts
@@ -59,6 +59,53 @@ test('snyk test command should fail when --packageManager is not specified corre
   });
 });
 
+test('snyk test command should fail when iac file is not specified', (t) => {
+  t.plan(1);
+  exec(`node ${main} iac test`, (err, stdout) => {
+    if (err) {
+      throw err;
+    }
+    t.match(
+      stdout.trim(),
+      'iac option works only with specified files',
+      'correct error output',
+    );
+  });
+});
+
+test('snyk test command should fail when iac file is not supported', (t) => {
+  t.plan(1);
+  exec(
+    `node ${main} iac test --file=./test/acceptance/workspaces/empty/readme.md`,
+    (err, stdout) => {
+      if (err) {
+        throw err;
+      }
+      t.match(
+        stdout.trim(),
+        'CustomError: Illegal infrastructure as code target file',
+        'correct error output',
+      );
+    },
+  );
+});
+
+test('snyk test command should fail when iac file is not supported', (t) => {
+  t.plan(1);
+  exec(
+    `node ${main} iac test --file=./test/acceptance/workspaces/helmconfig/Chart.yaml`,
+    (err, stdout) => {
+      if (err) {
+        throw err;
+      }
+      t.match(
+        stdout.trim(),
+        'CustomError: Not supported infrastructure as code target files in',
+        'correct error output',
+      );
+    },
+  );
+});
 test('`test multiple paths with --project-name=NAME`', (t) => {
   t.plan(1);
   exec(`node ${main} test pathA pathB --project-name=NAME`, (err, stdout) => {

diff --git a/test/acceptance/workspaces/helmconfig/Chart.yaml b/test/acceptance/workspaces/helmconfig/Chart.yaml