Skip to content

Commit

Permalink
fix: fix key XXX not found in packageToDepTreeMap
Browse files Browse the repository at this point in the history
Since the last change of introducing packageToDepTreeMap, we're seeing some errors in logs of "key XXX not found in packageToDepTreeMap"
This happens because current implementation ignores "extras" property (i.e. requests['security']) and identify duplicate "requests" children.
this small change doesn't add support for "extras" property, but simply ignores it in a more graceful way (no regression here)
  • Loading branch information
admons committed Apr 6, 2022
1 parent fdc05b7 commit 3bd2ade
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pysrc/pip_resolve.py
Expand Up @@ -84,6 +84,9 @@ def create_children_recursive(root_package, key_tree, ancestors, all_packages_ma
if DEPENDENCIES not in root_package:
root_package[DEPENDENCIES] = {}

if child_project_name in root_package[DEPENDENCIES]:
continue

if child_project_name in all_packages_map and child_project_name not in root_package[DEPENDENCIES]:
root_package[DEPENDENCIES][child_project_name] = 'true'
continue
Expand Down

0 comments on commit 3bd2ade

Please sign in to comment.