Merge pull request #50 from snyk/fix/fix-label-pruning-bug

fix: Fix label instance reuse bug during pruning
snyk · Mar 6, 2020 · 24f0506 · 24f0506
2 parents 2cb43d5 + c6f41ba
commit 24f0506
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/src/legacy/index.ts b/src/legacy/index.ts
@@ -283,7 +283,7 @@ async function buildSubtree(
     depTree.versionProvenance = nodeInfo.versionProvenance;
   }
   if (nodeInfo.labels) {
-    depTree.labels = nodeInfo.labels;
+    depTree.labels = { ...nodeInfo.labels };
   }
 
   const depInstanceIds = depGraph.getNodeDepsNodeIds(nodeId);

diff --git a/test/fixtures/pruneable-tree-multi-top-level-deps-pruned.json b/test/fixtures/pruneable-tree-multi-top-level-deps-pruned.json
@@ -22,6 +22,9 @@
                     "vuln": "yes"
                   }
                 }
+              },
+              "labels": {
+                "foo": "bar"
               }
             }
           }
@@ -34,6 +37,7 @@
               "name": "c",
               "version": "1.0.0",
               "labels": {
+                "foo": "bar",
                 "pruned": "true"
               }
             }
@@ -60,6 +64,9 @@
                     "vuln": "yes"
                   }
                 }
+              },
+              "labels": {
+                "foo": "bar"
               }
             }
           }

diff --git a/test/fixtures/pruneable-tree-multi-top-level-deps.json b/test/fixtures/pruneable-tree-multi-top-level-deps.json
@@ -22,6 +22,9 @@
                     "vuln": "yes"
                   }
                 }
+              },
+              "labels": {
+                "foo": "bar"
               }
             }
           }
@@ -41,6 +44,9 @@
                     "vuln": "yes"
                   }
                 }
+              },
+              "labels": {
+                "foo": "bar"
               }
             }
           }
@@ -66,6 +72,9 @@
                     "vuln": "yes"
                   }
                 }
+              },
+              "labels": {
+                "foo": "bar"
               }
             }
           }