Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update option parameters #29

Merged
merged 1 commit into from Jul 25, 2022
Merged

Update option parameters #29

merged 1 commit into from Jul 25, 2022

Conversation

jopemachine
Copy link
Contributor

Summary

  • milliseconds is moved into options
  • message is separated with fallback
  • message is moved into options
  • fallback is moved into options

Reference

sindresorhus/p-wait-for#24

@jopemachine
WIP
3a7483f 
WIP

WIP
@jopemachine jopemachine marked this pull request as ready for review July 25, 2022 05:01
@sindresorhus sindresorhus merged commit d7920ca into sindresorhus:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jopemachine @sindresorhus