Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure milliseconds argument is not NaN #25

Merged
merged 5 commits into from Oct 23, 2021
Merged

Ensure milliseconds argument is not NaN #25

merged 5 commits into from Oct 23, 2021

Conversation

Kikobeats
Copy link
Contributor

@Kikobeats Kikobeats commented Oct 23, 2021 •
edited

Because

milliseconds < 0

is not enough since

NaN < 0 // => false

@sindresorhus sindresorhus changed the title ensure milliseconds is not NaN Ensure milliseconds argument is not NaN Oct 23, 2021
@sindresorhus sindresorhus merged commit 6b6c4e8 into sindresorhus:main Oct 23, 2021
@Kikobeats Kikobeats deleted the patch-1 branch October 24, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kikobeats @sindresorhus