Handle there being no parent module #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2020
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue when there no parent module
Description
As describe here #18 it seems when there no parent module, we have an error. This is typically the case when we bundle with:
In this GitHub Action https://github.com/JulienKode/pull-request-name-linter-action we use import-fresh (actually commitlint/load are using it) and we bundle it with ncc
As we have a final bundle we do not have parent-module so we have this issue: JulienKode/pull-request-name-linter-action#61
Testing
I've added a test case to cover that, I did the module mocking manually. I understand that it's not the best way as some libraries can do that for us.
Fixes #18
Fixes #14