fix: disconnects should now work again on unix based systems (#2120)

serialport · Aug 7, 2020 · 2801301 · 2801301
1 parent f88c75e
commit 2801301
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/bindings/lib/unix-read.js b/packages/bindings/lib/unix-read.js
@@ -46,7 +46,7 @@ const unixRead = async ({ binding, buffer, offset, length, fsReadAsync = readAsy
       err.errno === -1 // generic error
 
     if (disconnectError) {
-      err.canceled = true
+      err.disconnect = true
       logger('disconnecting', err)
     }
 

diff --git a/packages/bindings/lib/unix-read.test.js b/packages/bindings/lib/unix-read.test.js
@@ -95,10 +95,10 @@ describe('unixRead', () => {
     const err = await shouldReject(unixRead({ binding: mock, buffer: readBuffer, offset: 0, length: 8, fsReadAsync }))
     assert.isTrue(err.canceled)
   })
-  it('rejects a canceled error when fsread errors a disconnect error', async () => {
+  it('rejects a disconnected error when fsread errors a disconnect error', async () => {
     const readBuffer = Buffer.alloc(8, 0)
     const fsReadAsync = makeFsReadError('EBADF')
     const err = await shouldReject(unixRead({ binding: mock, buffer: readBuffer, offset: 0, length: 8, fsReadAsync }))
-    assert.isTrue(err.canceled)
+    assert.isTrue(err.disconnect)
   })
 })