Fix a regression in binary verification

A regression introduced in 22c560c broke binary verification causing the binary to always be built locally. Fixes #1434
sass · Mar 31, 2016 · 0fa5e5e · 0fa5e5e
1 parent d76923b
commit 0fa5e5e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/extensions.js b/lib/extensions.js
@@ -167,7 +167,6 @@ function getBinaryUrl() {
  * callers wants to throw if file not exists before
  * returning.
  *
- * @param {Boolean} throwIfNotExists
  * @api public
  */
 
@@ -189,6 +188,13 @@ function getBinaryPath() {
   return binaryPath;
 }
 
+/**
+ * Does the supplied binary path exist
+ *
+ * @param {String} binaryPath
+ * @api public
+ */
+
 function hasBinary(binaryPath) {
   return fs.existsSync(binaryPath);
 }

diff --git a/scripts/install.js b/scripts/install.js
@@ -81,7 +81,7 @@ function applyProxy(options, cb) {
  */
 
 function checkAndDownloadBinary() {
-  if (sass.getBinaryPath()) {
+  if (sass.hasBinary(sass.getBinaryPath())) {
     return;
   }
 
@@ -97,7 +97,7 @@ function checkAndDownloadBinary() {
         return;
       }
 
-      console.log('Binary downloaded and installed at', sass.binaryPath());
+      console.log('Binary downloaded and installed at', sass.getBinaryPath());
     });
   });
 }