migrate to eslint

.github/workflows/ci.yaml

@@ -28,14 +28,18 @@ jobs:
       with:
         path: |
           ~/.npm
+          ~/.pnpm-store
           ~/.cache/pip
         key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('package-lock.json') }}-${{ hashFiles('requirements.txt') }}
         restore-keys: |
           ${{ runner.os }}-build-${{ env.cache-name }}-
           ${{ runner.os }}-build-
           ${{ runner.os }}-
-    - name: install node dependencies
-      run: npm ci --ignore-scripts
+    - name: install node packages
+      uses: pnpm/action-setup@v1.2.1
+      with:
+        version: latest
+        run_install: true
     - run: npm test
     - name: Publish
       run: |

bin/branches.ts

@@ -18,10 +18,10 @@ async function main() {
   for (const branch of branches.data) {
     if (branch.name.match(/^[0-9]+$/)) {
       const issue = await octokit.issues.get({ owner, repo, issue_number: parseInt(branch.name) })
-      if (issue.data.state !== 'open') console.log(branch.name, issue.data.state) // tslint:disable-line:no-console
+      if (issue.data.state !== 'open') console.log(branch.name, issue.data.state) // eslint-disable-line no-console
 
     } else if (branch.name !== 'master' && branch.name !== 'gh-pages') {
-      console.log(branch.name) // tslint:disable-line:no-console
+      console.log(branch.name) // eslint-disable-line no-console
 
     }
   }

bin/link.ts

@@ -15,13 +15,13 @@ const build = path.join(root, 'build')
 const zotero = process.argv[2]
 
 if (!zotero) {
-  console.log('No directory specified') // tslint:disable-line:no-console
+  console.log('No directory specified') // eslint-disable-line no-console
   process.exit(1)
 }
 
 const extensions = path.join(zotero, 'extensions')
 if (!fs.existsSync(extensions)) {
-  console.log(`${extensions} does not exist`) // tslint:disable-line:no-console
+  console.log(`${extensions} does not exist`) // eslint-disable-line no-console
   process.exit(1)
 }
 

bin/release.ts

@@ -20,22 +20,22 @@ import version from '../version'
 const xpi = `${pkg.name}-${version}.xpi`
 
 const PRERELEASE = false
-// tslint:disable-next-line:no-magic-numbers
+// eslint-disable-next-line no-magic-numbers
 const EXPIRE_BUILDS = moment().subtract(7, 'days').toDate().toISOString()
 
 function bail(msg, status = 1) {
-  console.log(msg) // tslint:disable-line:no-console
+  console.log(msg) // eslint-disable-line no-console
   process.exit(status)
 }
 
 const dryRun = !CI.service
 if (dryRun) {
-  console.log('Not running on CI service, switching to dry-run mode') // tslint:disable-line:no-console
+  console.log('Not running on CI service, switching to dry-run mode') // eslint-disable-line no-console
   CI.branch = require('current-git-branch')()
 }
 
 function report(msg) {
-  console.log(`${dryRun ? 'dry-run: ' : ''}${msg}`) // tslint:disable-line:no-console
+  console.log(`${dryRun ? 'dry-run: ' : ''}${msg}`) // eslint-disable-line no-console
 }
 
 if (CI.pull_request) bail('Not releasing pull requests', 0)
@@ -83,7 +83,7 @@ async function announce(issue, release) {
   try {
     await octokit.issues.createComment({ owner, repo, issue_number: issue, body: msg })
   } catch (error) {
-    console.log(`Failed to announce '${build}: ${reason}' on ${issue}`) // tslint:disable-line:no-console
+    console.log(`Failed to announce '${build}: ${reason}' on ${issue}`) // eslint-disable-line no-console
   }
 }
 

bin/zipup.ts

@@ -10,7 +10,7 @@ import version from '../version'
 const [ , , source, target ] = process.argv
 
 const xpi = path.join(root, 'xpi', `${target}-${version}.xpi`)
-console.log(`creating ${xpi}`) // tslint:disable-line:no-console
+console.log(`creating ${xpi}`) // eslint-disable-line no-console
 if (fs.existsSync(xpi)) fs.unlinkSync(xpi)
 
 const archive = archiver.create('zip', {})

continuous-integration.ts

@@ -71,4 +71,4 @@ class ContinuousIntegrationSingleton {
   }
 }
 
-export let ContinuousIntegration = new ContinuousIntegrationSingleton // tslint:disable-line:variable-name
+export let ContinuousIntegration = new ContinuousIntegrationSingleton // eslint-disable-line @typescript-eslint/naming-convention,no-underscore-dangle,id-blacklist,id-match

copy-assets.ts

@@ -1,4 +1,4 @@
-// tslint:disable:no-console
+/* eslint-disable no-console */
 
 import * as fs from 'fs-extra'
 import * as glob from 'glob'

make-dirs.ts

@@ -1,4 +1,4 @@
-// tslint:disable:no-console
+/* eslint-disable no-console */
 
 import * as rimraf from 'rimraf'
 import * as fs from 'fs-extra'