feat!: support v18.x

* Remove `closed()` monkey-patch, rely on connectionState instead (GH-1888)
* fix IPv6 url by supporting new server.address().family format
* add node 18 to GH Actions

Co-authored-by: mary marchini <oss@mmarchini.me>

.github/workflows/ci.yml

@@ -30,6 +30,7 @@ jobs:
         node-version:
           - 14.x
           - 16.x
+          - 18.x
     runs-on: ${{matrix.os}}
     steps:
       - uses: actions/checkout@v2

lib/request.js

@@ -2,7 +2,6 @@
 
 'use strict';
 
-const { emitWarning } = require('node:process');
 var url = require('url');
 var sprintf = require('util').format;
 
@@ -837,25 +836,6 @@ function patch(Request) {
         return self._connectionState;
     };
 
-    /**
-     * Returns true when connection state is "close"
-     *
-     * @private
-     * @memberof Request
-     * @instance
-     * @function closed
-     * @returns {Boolean} is closed
-     */
-    Request.prototype.closed = function closed() {
-        emitWarning(
-            'restify req.closed is deprecated, will be removed on Restify 10',
-            'RestifyDeprecationWarning',
-            'RestifyDEPReqClosed'
-        );
-        var self = this;
-        return self.connectionState() === 'close';
-    };
-
     /**
      * Returns the route object to which the current request was matched to.
      *

lib/server.js

@@ -257,7 +257,7 @@ function Server(options) {
 
         if (addr) {
             str +=
-                addr.family === 'IPv6'
+                addr.family === 'IPv6' || addr.family === 6
                     ? '[' + addr.address + ']'
                     : addr.address;
             str += ':';

test/request.test.js

@@ -275,27 +275,3 @@ test('should emit restifyDone event when request is fully served with error', fu
         clientDone = true;
     });
 });
-
-test('should emit warning if closed is called', function(t) {
-    let warningCalled = false;
-    SERVER.get('/ping/:name', function(req, res, next) {
-        function testWarning(warning) {
-            t.equal(warning.name, 'RestifyDeprecationWarning');
-            t.equal(warning.code, 'RestifyDEPReqClosed');
-            t.ok(warning.stack);
-            warningCalled = true;
-
-            res.send('ok');
-            return next();
-        }
-        process.once('warning', testWarning);
-        t.notOk(req.closed());
-    });
-
-    CLIENT.get('/ping/lagavulin', function(err, _, res) {
-        t.ifError(err);
-        t.equal(res.statusCode, 200);
-        t.ok(warningCalled);
-        t.end();
-    });
-});