Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: remy/nodemon
base: 7d6c1a88a10f02d3f00b6e0635f982bb74ce5708
Choose a base ref
...
head repository: remy/nodemon
compare: ee92ee470b37d4cb69429198677afb19ede5100c
Choose a head ref
  • 16 commits
  • 17 files changed
  • 7 contributors

Commits on Nov 20, 2019

  1. chore: add logo to site

    [skip ci]
    remy committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    3d90879 View commit details
    Browse the repository at this point in the history
  2. choe: merge master

    * refs/remotes/origin/master:
      fix: to avoid confusion like in #1528, always report used extension
      fix: langauge around "watching" (#1591)
      docs: README Grammar (#1601)
    remy committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    3a2eaf7 View commit details
    Browse the repository at this point in the history
  3. docs: add to faq

    [skip ci]
    remy committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    95a4c09 View commit details
    Browse the repository at this point in the history
  4. chore: Merge branch 'master'

    [skip ci]
    
    * 'master' of github.com:remy/nodemon:
      fix: Replace `jade` references by `pug`
      chore: test funding.yml change
      chore: update funding
      test: ensure ignore relative paths
    remy committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    b58cf7d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0e6ba3c View commit details
    Browse the repository at this point in the history
  6. docs: add license file

    markokajzer authored and remy committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    6781b40 View commit details
    Browse the repository at this point in the history
  7. feat: update chokidar to v3

    BREAKING CHANGE:
    
    Massive CPU & RAM consumption improvements. 17x package & deps size reduction.
    radum authored and remy committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    9a67f36 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. fix: ubuntu loop waiting for sub processes

    Fixes #1633
    
    Multiple parts but all localised to run.js:
    
    - Refactor the kill logic to be simpler
    - Consistently use pstree to determine sub process list
    - Pipe stderr through nodemon to squash `sh -c` error warning
    
    Bug was caused by waiting on multiple sub processes and if they all
    ended the logic would only subtract one from the count list (rather
    than the total number).
    
    I've refactored the code so that it doesn't use the `kill -0 <pid>` as
    this was a little confusing to read (it's effectively a no op) and
    switched to using pstree to test if any sub processes are still running.
    
    The logic for killing the processes has also been refactored to
    simplify. Before it would fork the logic based on whether `ps` existed
    on the system.
    
    Now it uses the same logic with the exception of the kill signal sent -
    when `ps` isn't on the system, we have to send numeric signals (I can't
    remember how I found that out, but I do remember it was a painful
    process!).
    
    The last part required due to a side effect of the refactor on kill:
    when a kill signial is sent to `sh -c` the shell prints a warning.
    Details on how to replicate: https://git.io/Je6d0
    
    To squash this, I track if the process is about to be killed (by
    flagging the sub process right before the kill function call) and if
    there's an error whilst shutdown is in effect, the error is only printed
    to nodemon's detailed output (using nodemon -V).
    remy committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    ed91703 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. fix: pipe stderr correctly

    Fixes #1638
    
    This also simplifies the shutdown process by sending the kill signal to
    the sub-process - thus ensuring we don't get the weird "User defined
    singal" from the shell.
    
    This commit also includes a test to ensure this doesn't happen again.
    remy committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    47dfb8b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    496c335 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. test: fix fork test

    I accidently dropped the part of the test that checks that the script
    correctly started 😱
    remy committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    cd45d74 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. Configuration menu
    Copy the full SHA
    c279760 View commit details
    Browse the repository at this point in the history
  2. docs: changed verbose logging and CLI documentation to reflect suppor…

    …t single file watch functionality
    concision authored and remy committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    9bd07eb View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. fix: package.json & package-lock.json to reduce vulnerabilities

    The following vulnerabilities are fixed with an upgrade:
    - https://snyk.io/vuln/SNYK-JS-DOTPROP-543489
    snyk-bot authored and remy committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    a4490e2 View commit details
    Browse the repository at this point in the history
  2. test: fix failing test when required

    I suspect, though not 100% sure, that this test fails because it was
    being required and when so, chokidar is already watching and thus fires
    before the config is loaded.
    remy committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    33ae6da View commit details
    Browse the repository at this point in the history
  3. test: split require tests

    remy committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    ee92ee4 View commit details
    Browse the repository at this point in the history