Fix preloaded state type #4078
Merged
Fix preloaded state type #4078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9ab0a70:
|
|
Please format |
|
Unfortunately, the formatter for this repo is for whatever reason not working correctly on my system and messes up all files. I had pinged @markerikson if he could format over it, but I assume he forgot about it ^^ Mark, can you give this a small "format" please? :) |
|
Can this be merged and released please ? thanks |
|
Will this be merged soon? |
|
Ironically, I just ran into this one myself helping someone out tonight and filed #4201 to fix it.... and then Lenz reminded me this PR exists :) Merging and publishing 4.1.2 momentarily. |
bors bot
pushed a commit
to ttbud/ttbud
that referenced
this pull request
Dec 10, 2021
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [redux](http://redux.js.org) ([source](https://togithub.com/reduxjs/redux)) | [`4.1.1` -> `4.1.2`](https://renovatebot.com/diffs/npm/redux/4.1.1/4.1.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>reduxjs/redux</summary> ### [`v4.1.2`](https://togithub.com/reduxjs/redux/releases/v4.1.2) [Compare Source](https://togithub.com/reduxjs/redux/compare/v4.1.1...v4.1.2) This release fixes a small specific TS types issue where state types that had a nested `unknown` field inside would cause compilation failures when used as the `preloadedState` argument. #### What's Changed - Fix preloaded state type by [@​phryneas](https://togithub.com/phryneas) in [reduxjs/redux#4078 **Full Changelog**: reduxjs/redux@v4.1.1...v4.1.2 </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/ttbud/ttbud).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 🐛 fix PreloadedState type on
unknownabout: Fixes a type problem brought up in #4076
PR Type
Does this PR add a new feature, or fix a bug?
Fixes a bug
Why should this PR be included?
Fixes a slight misbehavior of
PreloadedStatein the case the original state type containedunknownat some point.Checklist
Unfortunately, locally the formatter runs amok and linter/tests don't wanna run. I hope everything is alright.
Bug Fixes
Before,
PreloadedState<{state: unknown}>returned{ state: never }, now it returns{ state: unknown }How does this PR fix the problem?
Return the original type
Sin the inner condition instead ofnever. Seems to be more reasonable.