#2808 Preloaded state is now selectively partial (instead of deeply partial). #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for redux-docs ready! Built with commit fba87fe |
timdorr
reviewed
Jul 30, 2019
Found a better way to type check CombinedState which allows the $CombinedState symbol property marker to be optional. Since it's optional, it's no longer necessary to strip it off in the Reducer state parameter type and return type. This leaves the type definition for Reducer unmodified, reduces the number of types required by one, and makes the resolved types and stack traces clearer.
Shakeskeyboarde
changed the title
|
It looks like we can get rid of |
Leaving the definition in place as removing it would be a breaking change.
|
Unsure why prettier doesn't like |
|
Ah, this branch was behind master, which had prettier formatting flaws in the UsingObjectSpreadOperator.md. Fixed the formatting and re-pushed. |
|
@ChrisAckerman Do you want to resolve the conflicts here? |
|
@timdorr Done. |
|
Awesome, thanks! |
Closed
This was referenced Mar 11, 2020
This was referenced Mar 23, 2020
This was referenced Mar 30, 2020
This was referenced Apr 6, 2020
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
…eeply partial). (reduxjs#3485) * Preloaded state is now selectively partial (instead of deeply partial). * Improved CombinedState, PreloadedState, and removed UnCombinedState. Found a better way to type check CombinedState which allows the $CombinedState symbol property marker to be optional. Since it's optional, it's no longer necessary to strip it off in the Reducer state parameter type and return type. This leaves the type definition for Reducer unmodified, reduces the number of types required by one, and makes the resolved types and stack traces clearer. * Small change to the description of CombinedState. * Removed DeepPartial import from tests. Leaving the definition in place as removing it would be a breaking change. * Made prettier happy. * Made prettier happy with UsingObjectSpreadOperator.md Former-commit-id: 41c0612 Former-commit-id: b41174f
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
…eeply partial). (reduxjs#3485) * Preloaded state is now selectively partial (instead of deeply partial). * Improved CombinedState, PreloadedState, and removed UnCombinedState. Found a better way to type check CombinedState which allows the $CombinedState symbol property marker to be optional. Since it's optional, it's no longer necessary to strip it off in the Reducer state parameter type and return type. This leaves the type definition for Reducer unmodified, reduces the number of types required by one, and makes the resolved types and stack traces clearer. * Small change to the description of CombinedState. * Removed DeepPartial import from tests. Leaving the definition in place as removing it would be a breaking change. * Made prettier happy. * Made prettier happy with UsingObjectSpreadOperator.md Former-commit-id: 41c0612 Former-commit-id: b41174f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2808 by using a specialized (but effectively NO-OP) type
CombinedStateto indicate that theReducerreturned bycombineReducers()has a generic state type which should be considered shallowly partial.NOTE: Requires Typescript >= 3.5 to work correctly.