Update pathSatisfies to handles empty path arguments (#2791)

* Update `pathSatisfies` to handles empty `path` arguments * Add negative test for `pathSatisfies` with empty `path`
ramda · Mar 1, 2019 · ac58c96 · ac58c96
1 parent b25ac73
commit ac58c96
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/source/pathSatisfies.js b/source/pathSatisfies.js
@@ -20,8 +20,9 @@ import path from './path';
  * @example
  *
  *      R.pathSatisfies(y => y > 0, ['x', 'y'], {x: {y: 2}}); //=> true
+ *      R.pathSatisfies(R.is(Object), [], {x: {y: 2}}); //=> true
  */
 var pathSatisfies = _curry3(function pathSatisfies(pred, propPath, obj) {
-  return propPath.length > 0 && pred(path(propPath, obj));
+  return pred(path(propPath, obj));
 });
 export default pathSatisfies;
diff --git a/test/pathSatisfies.js b/test/pathSatisfies.js
@@ -14,8 +14,12 @@ describe('pathSatisfies', function() {
     eq(R.pathSatisfies(isPositive, ['x', 'y'], {x: {z: 42}}), false);
   });
 
-  it('returns false if the path is empty', function() {
-    eq(R.pathSatisfies(isPositive, [], {x: {z: 42}}), false);
+  it('handles empty paths by applying pred to data: positive', function() {
+    eq(R.pathSatisfies(R.is(Object), [], {x: {z: 42}}), true);
+  });
+
+  it('handles empty paths by applying pred to data: negative', function() {
+    eq(R.pathSatisfies(R.has('y'), [], {x: {z: 42}}), false);
   });
 
   it('returns false otherwise', function() {