Skip to content

Commit

Permalink
chore: bundle vendor code (#9016)
Browse files Browse the repository at this point in the history
This PR removes the manual vendoring process. Third party code can now
be updated using the typical NPM pipeline with types/code bundling done
through Rollup.
  • Loading branch information
jrandolf committed Sep 28, 2022
1 parent d06a905 commit f8de7b1
Show file tree
Hide file tree
Showing 27 changed files with 322 additions and 488 deletions.
2 changes: 1 addition & 1 deletion .eslintrc.js
Expand Up @@ -103,7 +103,7 @@ module.exports = {
{
name: 'mitt',
message:
'Import Mitt from the vendored location: vendor/mitt/src/index.js',
'Import Mitt from the vendored location: vendor/mitt/index.js',
},
],
},
Expand Down
1 change: 0 additions & 1 deletion .prettierignore
Expand Up @@ -42,6 +42,5 @@ CHANGELOG.md
package-lock.json
package.json
test/assets/
vendor/
docs/
versioned_*/
2 changes: 1 addition & 1 deletion docs/api/puppeteer.eventtype.md
Expand Up @@ -7,5 +7,5 @@ sidebar_label: EventType
**Signature:**

```typescript
export declare type EventType = string | symbol;
declare type EventType = string | symbol;
```
2 changes: 1 addition & 1 deletion docs/api/puppeteer.handler.md
Expand Up @@ -7,5 +7,5 @@ sidebar_label: Handler
**Signature:**

```typescript
export declare type Handler<T = any> = (event?: T) => void;
declare type Handler<T = any> = (event?: T) => void;
```
213 changes: 213 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions package.json
Expand Up @@ -57,10 +57,11 @@
"check:protocol-revision": "tsx scripts/ensure-correct-devtools-protocol-package",
"check:pinned-deps": "tsx scripts/ensure-pinned-deps",
"build": "npm run build:prod",
"build:dev": "run-s generate:sources build:tsc:dev generate:artifacts",
"build:prod": "run-s generate:sources build:tsc:prod generate:artifacts",
"build:dev": "run-s generate:sources build:tsc:dev && run-p bundle:vendor generate:artifacts",
"build:prod": "run-s generate:sources build:tsc:prod && run-p bundle:vendor generate:artifacts",
"build:tsc:dev": "tsc -b test",
"build:tsc:prod": "tsc -b tsconfig.lib.json"
"build:tsc:prod": "tsc -b tsconfig.lib.json",
"bundle:vendor": "rollup --config rollup.vendor.config.js"
},
"files": [
"lib",
Expand Down Expand Up @@ -129,12 +130,16 @@
"jpeg-js": "0.4.4",
"mime": "3.0.0",
"minimist": "1.2.6",
"mitt": "2.1.0",
"mocha": "10.0.0",
"ncp": "2.0.0",
"npm-run-all": "4.1.5",
"pixelmatch": "5.3.0",
"pngjs": "6.0.0",
"prettier": "2.7.1",
"rollup": "2.79.1",
"rollup-plugin-dts": "4.2.2",
"rollup-plugin-node-resolve": "5.2.0",
"semver": "7.3.7",
"sinon": "14.0.0",
"source-map-support": "0.5.21",
Expand Down

0 comments on commit f8de7b1

Please sign in to comment.