Skip to content

Commit

Permalink
refactor: use common debugError (#11039)
Browse files Browse the repository at this point in the history
  • Loading branch information
Lightning00Blade committed Sep 26, 2023
1 parent 48f9382 commit e853e63
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 11 deletions.
2 changes: 1 addition & 1 deletion packages/puppeteer-core/src/bidi/Browser.ts
Expand Up @@ -28,6 +28,7 @@ import {BrowserContextEvent} from '../api/BrowserContext.js';
import {type Page} from '../api/Page.js';
import {type Target} from '../api/Target.js';
import {type Handler} from '../common/EventEmitter.js';
import {debugError} from '../common/util.js';
import {type Viewport} from '../common/Viewport.js';

import {BidiBrowserContext} from './BrowserContext.js';
Expand All @@ -39,7 +40,6 @@ import {
BiDiPageTarget,
type BidiTarget,
} from './Target.js';
import {debugError} from './util.js';

/**
* @internal
Expand Down
2 changes: 1 addition & 1 deletion packages/puppeteer-core/src/bidi/BrowsingContext.ts
Expand Up @@ -6,12 +6,12 @@ import {type Connection as CdpConnection} from '../cdp/Connection.js';
import {type PuppeteerLifeCycleEvent} from '../cdp/LifecycleWatcher.js';
import {TargetCloseError} from '../common/Errors.js';
import {type EventType} from '../common/EventEmitter.js';
import {debugError} from '../common/util.js';
import {assert} from '../util/assert.js';
import {Deferred} from '../util/Deferred.js';

import {type BidiConnection} from './Connection.js';
import {BidiRealm} from './Realm.js';
import {debugError} from './util.js';

/**
* @internal
Expand Down
2 changes: 1 addition & 1 deletion packages/puppeteer-core/src/bidi/Connection.ts
Expand Up @@ -20,9 +20,9 @@ import {CallbackRegistry} from '../cdp/Connection.js';
import {type ConnectionTransport} from '../common/ConnectionTransport.js';
import {debug} from '../common/Debug.js';
import {EventEmitter} from '../common/EventEmitter.js';
import {debugError} from '../common/util.js';

import {type BrowsingContext, cdpSessions} from './BrowsingContext.js';
import {debugError} from './util.js';

const debugProtocolSend = debug('puppeteer:webDriverBiDi:SEND ►');
const debugProtocolReceive = debug('puppeteer:webDriverBiDi:RECV ◀');
Expand Down
2 changes: 1 addition & 1 deletion packages/puppeteer-core/src/bidi/ExposedFunction.ts
Expand Up @@ -17,14 +17,14 @@
import * as Bidi from 'chromium-bidi/lib/cjs/protocol/protocol.js';

import {type Awaitable, type FlattenHandle} from '../common/types.js';
import {debugError} from '../common/util.js';
import {assert} from '../util/assert.js';
import {Deferred} from '../util/Deferred.js';
import {interpolateFunction, stringifyFunction} from '../util/Function.js';

import {type BidiConnection} from './Connection.js';
import {type BidiFrame} from './Frame.js';
import {BidiSerializer} from './Serializer.js';
import {debugError} from './util.js';

type SendArgsChannel<Args> = (value: [id: number, args: Args]) => void;
type SendResolveChannel<Ret> = (
Expand Down
8 changes: 1 addition & 7 deletions packages/puppeteer-core/src/bidi/util.ts
Expand Up @@ -16,17 +16,11 @@

import type * as Bidi from 'chromium-bidi/lib/cjs/protocol/protocol.js';

import {debug} from '../common/Debug.js';
import {PuppeteerURL} from '../common/util.js';
import {PuppeteerURL, debugError} from '../common/util.js';

import {type BidiRealm} from './Realm.js';
import {BidiSerializer} from './Serializer.js';

/**
* @internal
*/
export const debugError = debug('puppeteer:error');

/**
* @internal
*/
Expand Down

0 comments on commit e853e63

Please sign in to comment.