Skip to content

Commit

Permalink
refactor: remove unused promise (#7830)
Browse files Browse the repository at this point in the history
  • Loading branch information
benallfree committed Dec 9, 2021
1 parent c034294 commit 71cc1b9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 21 deletions.
2 changes: 0 additions & 2 deletions src/common/NetworkEventManager.ts
Expand Up @@ -3,8 +3,6 @@ import { HTTPRequest } from './HTTPRequest.js';

export type QueuedEventGroup = {
responseReceivedEvent: Protocol.Network.ResponseReceivedEvent;
promise: Promise<void>;
resolver: () => void;
loadingFinishedEvent?: Protocol.Network.LoadingFinishedEvent;
loadingFailedEvent?: Protocol.Network.LoadingFailedEvent;
};
Expand Down
20 changes: 1 addition & 19 deletions src/common/NetworkManager.ts
Expand Up @@ -22,11 +22,7 @@ import { helper, debugError } from './helper.js';
import { Protocol } from 'devtools-protocol';
import { HTTPRequest } from './HTTPRequest.js';
import { HTTPResponse } from './HTTPResponse.js';
import {
FetchRequestId,
NetworkEventManager,
NetworkRequestId,
} from './NetworkEventManager.js';
import { FetchRequestId, NetworkEventManager } from './NetworkEventManager.js';

/**
* @public
Expand Down Expand Up @@ -480,28 +476,15 @@ export class NetworkManager extends EventEmitter {
.shift();
if (!extraInfo) {
// Wait until we get the corresponding ExtraInfo event.
let resolver = null;
const promise = new Promise<void>((resolve) => (resolver = resolve));
this._networkEventManager.queueEventGroup(event.requestId, {
responseReceivedEvent: event,
promise,
resolver,
});
return;
}
}
this._emitResponseEvent(event, extraInfo);
}

responseWaitingForExtraInfoPromise(
networkRequestId: NetworkRequestId
): Promise<void> {
const responseReceived =
this._networkEventManager.getQueuedEventGroup(networkRequestId);
if (!responseReceived) return Promise.resolve();
return responseReceived.promise;
}

_onResponseReceivedExtraInfo(
event: Protocol.Network.ResponseReceivedExtraInfoEvent
): void {
Expand Down Expand Up @@ -530,7 +513,6 @@ export class NetworkManager extends EventEmitter {
if (queuedEvents.loadingFailedEvent) {
this._emitLoadingFailed(queuedEvents.loadingFailedEvent);
}
queuedEvents.resolver();
return;
}

Expand Down

0 comments on commit 71cc1b9

Please sign in to comment.