chore: add headful support for Firefox (#9004)

* chore: add headful support for Firefox * chore: update test expectation data for Firefox headful tests
puppeteer · Sep 23, 2022 · 5a1b8d2 · 5a1b8d2
1 parent c21c3ba
commit 5a1b8d2
Show file tree

Hide file tree

Showing 4 changed files with 176 additions and 152 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -193,6 +193,16 @@ jobs:
             xvfb: true
             node: 18
             suite: firefox-headless
+          - name: firefox-headful
+            machine: ubuntu-latest
+            xvfb: true
+            node: 16
+            suite: firefox-headful
+          - name: firefox-headful
+            machine: ubuntu-latest
+            xvfb: true
+            node: 18
+            suite: firefox-headful
           - name: firefox-bidi
             machine: ubuntu-latest
             xvfb: true

diff --git a/package.json b/package.json
@@ -30,7 +30,9 @@
     "test": "cross-env PUPPETEER_DEFERRED_PROMISE_DEBUG_TIMEOUT=20000 node utils/mochaRunner/lib/main.js",
     "test:types": "tsd",
     "test:install": "scripts/test-install.sh",
-    "test:firefox": "npm run test -- --test-suite firefox-headless",
+    "test:firefox": "run-s test:firefox:*",
+    "test:firefox:headless": "npm run test -- --test-suite firefox-headless",
+    "test:firefox:headful": "npm run test -- --test-suite firefox-headful",
     "test:chrome": "run-s test:chrome:*",
     "test:chrome:headless": "npm run test -- --test-suite chrome-headless",
     "test:chrome:headless-chrome": "npm run test -- --test-suite chrome-new-headless",