feat: browsers: recognize chromium as a valid browser (#9760)

puppeteer · Mar 6, 2023 · 04247a4 · 04247a4
1 parent 6777604
commit 04247a4
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/packages/browsers/src/browsers/browsers.ts b/packages/browsers/src/browsers/browsers.ts
@@ -20,11 +20,13 @@ import {Browser, BrowserPlatform, BrowserTag} from './types.js';
 
 export const downloadUrls = {
   [Browser.CHROME]: chrome.resolveDownloadUrl,
+  [Browser.CHROMIUM]: chrome.resolveDownloadUrl,
   [Browser.FIREFOX]: firefox.resolveDownloadUrl,
 };
 
 export const executablePathByBrowser = {
   [Browser.CHROME]: chrome.relativeExecutablePath,
+  [Browser.CHROMIUM]: chrome.relativeExecutablePath,
   [Browser.FIREFOX]: firefox.relativeExecutablePath,
 };
 
@@ -42,6 +44,7 @@ export async function resolveBuildId(
           return await firefox.resolveBuildId('FIREFOX_NIGHTLY');
       }
     case Browser.CHROME:
+    case Browser.CHROMIUM:
       switch (tag as BrowserTag) {
         case BrowserTag.LATEST:
           return await chrome.resolveBuildId(platform, 'latest');

diff --git a/packages/browsers/src/browsers/types.ts b/packages/browsers/src/browsers/types.ts
@@ -22,6 +22,7 @@ import * as firefox from './firefox.js';
  */
 export enum Browser {
   CHROME = 'chrome',
+  CHROMIUM = 'chromium',
   FIREFOX = 'firefox',
 }
 
@@ -39,6 +40,7 @@ export enum BrowserPlatform {
 
 export const downloadUrls = {
   [Browser.CHROME]: chrome.resolveDownloadUrl,
+  [Browser.CHROMIUM]: chrome.resolveDownloadUrl,
   [Browser.FIREFOX]: firefox.resolveDownloadUrl,
 };
 

diff --git a/packages/browsers/test/src/launcher.spec.ts b/packages/browsers/test/src/launcher.spec.ts
@@ -38,6 +38,18 @@ describe('launcher', () => {
     );
   });
 
+  it('should compute executable path for Chromium', () => {
+    assert.strictEqual(
+      computeExecutablePath({
+        browser: Browser.CHROMIUM,
+        platform: BrowserPlatform.LINUX,
+        buildId: '123',
+        cacheDir: 'cache',
+      }),
+      path.join('cache', 'chromium', 'linux-123', 'chrome-linux', 'chrome')
+    );
+  });
+
   it('should compute executable path for Firefox', () => {
     assert.strictEqual(
       computeExecutablePath({