Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObjC] Rename proto_package_to_prefix_mappings_path to package_to_prefix_mappings_path. #9552

Conversation

dnkoutso
Copy link
Contributor

@dnkoutso dnkoutso commented Feb 25, 2022

The file format is actually the reverse of the initial option so we now rename the option to match the file format to avoid confusion.

@dnkoutso dnkoutso force-pushed the rename_to_proto_package_to_prefix_mappings_path branch from cf1ee1b to 8c64b50 Compare February 25, 2022 17:27
Copy link
Contributor

@thomasvl thomasvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry I didn't notice when we revised the the PR initially.

@dnkoutso
Copy link
Contributor Author

No worries at all!

@thomasvl thomasvl merged commit 89c4031 into protocolbuffers:master Feb 25, 2022
@dnkoutso dnkoutso deleted the rename_to_proto_package_to_prefix_mappings_path branch February 25, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants