Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datatable: Filter icon gets highlighted without even applying the filter #3051

Closed
dgraceli opened this issue Jul 11, 2022 · 3 comments · Fixed by #3052
Closed

Datatable: Filter icon gets highlighted without even applying the filter #3051

dgraceli opened this issue Jul 11, 2022 · 3 comments · Fixed by #3052
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.3.0

Comments

@dgraceli
Copy link

Describe the bug

image

Reproducer

No response

PrimeReact version

8.1.0

React version

17.x

Language

ES5

Build / Runtime

Next.js

Browser(s)

chrome

Steps to reproduce the behavior

Goto Filter select any dropdown and unselect , filter will get highlighted even user unselects, same behavior for search input and date selection as well.

Expected behavior

No response
@dgraceli dgraceli added Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a defect related to a specific component. labels Jul 11, 2022
@melloware melloware changed the title Filter icon gets highlighted without even applying the filter Datatable: Filter icon gets highlighted without even applying the filter Jul 11, 2022
@melloware melloware added 👍 confirmed and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 11, 2022
@melloware
Copy link
Member

Confirmed it happens in the showcase on the "Agent" column in menu mode. https://primefaces.org/primereact/datatable/filter/

melloware added a commit to melloware/primereact that referenced this issue Jul 11, 2022
@melloware
Fix primefaces#3051: Column filter showing as filtered when empty
48fe2d7
@melloware melloware mentioned this issue Jul 11, 2022
Merged
@melloware melloware self-assigned this Jul 11, 2022
@melloware melloware added this to the 9.0.0 milestone Jul 11, 2022
melloware added a commit that referenced this issue Jul 11, 2022
@melloware
Fix #3051: Column filter showing as filtered when empty (#3052)
93c558e
@mertsincan mertsincan modified the milestones: 9.0.0, 8.3.0 Jul 18, 2022
@dgraceli
Copy link
Author

dgraceli commented Feb 1, 2023 •
edited

Thanks for this fix. But the filter icon gets highlighted even without clicking on the apply button.
image

Selected 'Amy Elsner' from agent column-> did not click on apply-> closed the filter popup-> filter icon is highlighted

@melloware
Copy link
Member

@dgraceli can you open a new issue please. It looks like its related to it being a DropDown in the filter and not just an InputText.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.3.0
Development

Successfully merging a pull request may close this issue.

Fix #3051: Column filter showing as filtered when empty melloware/primereact
3 participants
@melloware @mertsincan @dgraceli