Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitButton: TypeScript Error "Cannot Find Name 'ButtonProps'" #3048

Closed
emilytoy opened this issue Jul 9, 2022 · 1 comment · Fixed by #3049
Closed

SplitButton: TypeScript Error "Cannot Find Name 'ButtonProps'" #3048

emilytoy opened this issue Jul 9, 2022 · 1 comment · Fixed by #3049
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component. Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
8.3.0

Comments

@emilytoy
Copy link
Contributor

emilytoy commented Jul 9, 2022

Describe the bug

In #3028, the optional loadingIcon prop was added, with type IconType<ButtonProps>. However, ButtonProps is not defined or imported in SplitButton.d.ts. This results in the following TypeScript error:

SplitButton TS Error

Reproducer

No response

PrimeReact version

8.2.0

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@emilytoy emilytoy added Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a defect related to a specific component. labels Jul 9, 2022
melloware added a commit to melloware/primereact that referenced this issue Jul 9, 2022
@melloware
Fix primefaces#3048: SplitButton loadingIcon correction
ca2361f
melloware added a commit to melloware/primereact that referenced this issue Jul 9, 2022
@melloware
Fix primefaces#3048: SplitButton loadingIcon correction
ec6e16e
@melloware melloware added Typescript Issue or pull request is *only* related to TypeScript definition and removed Type: Bug Issue contains a defect related to a specific component. Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 9, 2022
@melloware melloware self-assigned this Jul 9, 2022
@melloware melloware added this to the 9.0.0 milestone Jul 9, 2022
@melloware melloware mentioned this issue Jul 9, 2022
Merged
@melloware
Copy link
Member

Thanks for reporting!

melloware added a commit that referenced this issue Jul 9, 2022
@melloware
Fix #3048: SplitButton loadingIcon correction (#3049)
9abd43d
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Jul 18, 2022
@mertsincan mertsincan modified the milestones: 9.0.0, 8.3.0 Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component. Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
8.3.0
Development

Successfully merging a pull request may close this issue.

Fix #3048: SplitButton loadingIcon correction melloware/primereact
3 participants
@melloware @emilytoy @mertsincan