Fix various timing and impl bugs with tests

package.json

@@ -29,7 +29,7 @@
     "prepare": "husky install"
   },
   "devDependencies": {
-    "cli-testing-library": "1.0.0-alpha.6",
+    "cli-testing-library": "1.0.0-alpha.7",
     "eslint": "^8.0.1",
     "eslint-config-prettier": "^8.3.0",
     "eslint-plugin-prettier": "^4.0.0",

src/plop.js

@@ -22,7 +22,13 @@ const Plop = new Liftoff({
   v8flags: v8flags,
 });
 
-const progressSpinner = ora();
+const isInJest = process.env.NODE_ENV === "test";
+
+const progressSpinner = ora({
+  // Default is stderr
+  stream: isInJest ? process.stdout : process.stderr,
+  isEnabled: !isInJest,
+});
 
 /**
  * The function to pass as the second argument to `Plop.launch`

tests/actions.spec.js

@@ -2,7 +2,8 @@ const { renderPlop } = require("./render");
 const { resolve } = require("path");
 const { waitFor } = require("cli-testing-library");
 const fs = require("fs");
-const { getFilePath } = require("./file-helper");
+const { getFileHelper } = require("./file-helper");
+const { getFilePath } = getFileHelper();
 
 test("Plop to add and rename files", async () => {
   const expectedFilePath = await getFilePath(

tests/file-helper.js

@@ -1,27 +1,29 @@
 const fs = require("fs");
 const { resolve } = require("path");
 
-let cleanupFile = null;
+exports.getFileHelper = () => {
+  let cleanupFile = null;
 
-afterEach(() => {
-  if (!cleanupFile) return;
-  try {
-    fs.unlinkSync(cleanupFile);
-  } catch (e) {}
-  cleanupFile = null;
-});
+  afterEach(() => {
+    if (!cleanupFile) return;
+    try {
+      fs.unlinkSync(cleanupFile);
+    } catch (e) {}
+    cleanupFile = null;
+  });
 
-const getFilePath = async (path) => {
-  const expectedFilePath = resolve(__dirname, path);
+  const getFilePath = async (path) => {
+    const expectedFilePath = resolve(__dirname, path);
 
-  cleanupFile = expectedFilePath;
-  try {
-    await fs.promises.unlink(cleanupFile);
-  } catch (e) {}
+    cleanupFile = expectedFilePath;
+    try {
+      await fs.promises.unlink(cleanupFile);
+    } catch (e) {}
 
-  return expectedFilePath;
-};
+    return expectedFilePath;
+  };
 
-module.exports = {
-  getFilePath,
+  return {
+    getFilePath,
+  };
 };

tests/render.js

@@ -9,9 +9,16 @@ const { resolve } = require("path");
 function renderScript(script, args = [], opts = {}) {
   const { cwd = __dirname } = opts;
 
-  const rendered = render("npx", ["nyc", "--silent", "node", script, ...args], {
-    cwd,
-  });
+  const rendered = render(
+    resolve(__dirname, "../node_modules/.bin/nyc"),
+    ["--silent", "node", script, ...args],
+    {
+      cwd,
+      spawnOpts: {
+        env: { ...process.env, NODE_ENV: "test" },
+      },
+    }
+  );
 
   return rendered;
 }

tests/wrapper.spec.js

@@ -2,7 +2,8 @@ const { renderScript, renderPlop } = require("./render");
 const { resolve } = require("path");
 const { waitFor } = require("cli-testing-library");
 const fs = require("fs");
-const { getFilePath } = require("./file-helper");
+const { getFileHelper } = require("./file-helper");
+const { getFilePath } = getFileHelper();
 
 const renderWrapper = (...props) => {
   return renderScript(