Fixed stream metadata loss during prettification #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For streams with Symbol('metadata') true flag, pino metadata was lost during prettification
mcollina
reviewed
Feb 28, 2020
lib/tools.js
Outdated
| flushSync () { | ||
| if (warned) { | ||
| return | ||
| } | ||
| warned = true | ||
| dest.write(pretty(Object.assign({ | ||
| dest.write.call(this.destStreamContext, pretty(Object.assign({ |
There was a problem hiding this comment.
Copying streams metadata might cause significant issues. I would just attach the properties to the stream itself, mutating it.
There was a problem hiding this comment.
I think you can do something like:
function setMetadataProps (dest, that) {
if (dest[needsMetadataGsym] === true) {
dest.lastLevel = that.lastLevel
dest.lastMsg = that.lastMsg
dest.lastObj = that.lastObj
dest.lastTime = that.lastTime
dest.lastLogger = that.lastLogger
}
}and then call in both places.
There was a problem hiding this comment.
Created setMetadataProps function
…eam instance if need
This was referenced Mar 22, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For streams with Symbol('metadata') true flag, pino metadata was lost during prettification.
RE: pinojs/pino-multi-stream#31