Support new nestedKey config to avoid property name collisions with pino standard properties when logging objects #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmarkclements
requested changes
Jan 7, 2020
matthewadams
changed the title
|
@davidmarkclements are you good with this now? |
yes |
davidmarkclements
approved these changes
Jan 11, 2020
|
released https://github.com/pinojs/pino/releases/tag/v5.16.0 thank you @matthewadams |
This was referenced Mar 21, 2020
This was referenced Jun 6, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people log objects a lot. Those objects, in general, may have properties that conflict with pino's standard logging fields (
level,v,pid, etc). Also, when searching logs for logged objects, it's nice to always have them in a consistent location (that is, property of the root log record object).This PR adds a new config option
objectKeynestedKeythat causes log records to include a key whose name is the value of theobjectKeynestedKeyconfig, and whose value is the logged object (if it is an object and not a string). It allows folks using things like Kibana, StackDriver, MongoDB, etc, to consistently know the path in their log records to search for, and guarantees that no logged object's properties will conflict with pino's standard properties.