Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #1489 add test #1496

Merged
merged 1 commit into from Jul 18, 2022
Merged

resolves #1489 add test #1496

merged 1 commit into from Jul 18, 2022

Conversation

ggrossetie
Copy link
Contributor

resolves #1489

@ggrossetie ggrossetie mentioned this pull request Jul 17, 2022
Closed
mcollina
mcollina requested changes Jul 17, 2022
View reviewed changes
lib/multistream.js Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ab66179 into pinojs:master Jul 18, 2022
@ggrossetie ggrossetie deleted the issue-1489-listen-error branch July 18, 2022 09:28
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multistream should catch Error thrown by thread-stream
2 participants
@ggrossetie @mcollina