Never enable JSX in a .ts file (#7031)

parcel-bundler · Oct 7, 2021 · d2d4f1c · d2d4f1c
1 parent aafc318
commit d2d4f1c
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 9 deletions.
diff --git a/packages/core/integration-tests/test/integration/typescript-legacy-cast/index.ts b/packages/core/integration-tests/test/integration/typescript-legacy-cast/index.ts
@@ -0,0 +1,10 @@
+interface HeaderAction {}
+
+let setCurrentAction = (arg: any) => {};
+let getCurrentAction = () => {
+  return {};
+};
+
+const setAction = (fields: Partial<HeaderAction>) => {
+  setCurrentAction({ ...<HeaderAction>getCurrentAction(), ...fields });
+};
diff --git a/packages/core/integration-tests/test/integration/typescript-legacy-cast/package.json b/packages/core/integration-tests/test/integration/typescript-legacy-cast/package.json
@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "react": "*"
+  }
+}
diff --git a/packages/core/integration-tests/test/typescript.js b/packages/core/integration-tests/test/typescript.js
@@ -193,5 +193,15 @@ describe('typescript', function() {
         fromTsx: text,
       });
     });
+
+    it('should handle legacy cast in .ts file', async function() {
+      if (config != null) {
+        return;
+      }
+      await bundle(
+        path.join(__dirname, '/integration/typescript-legacy-cast/index.ts'),
+        {config},
+      );
+    });
   }
 });
diff --git a/packages/transformers/js/src/JSTransformer.js b/packages/transformers/js/src/JSTransformer.js
@@ -14,8 +14,8 @@ import {validateSchema, remapSourceLocation} from '@parcel/utils';
 import {isMatch} from 'micromatch';
 
 const JSX_EXTENSIONS = {
-  '.jsx': true,
-  '.tsx': true,
+  jsx: true,
+  tsx: true,
 };
 
 const JSX_PRAGMA = {
@@ -222,12 +222,7 @@ export default (new Transformer({
         }
       }
 
-      isJSX = Boolean(
-        compilerOptions?.jsx ||
-          pragma ||
-          JSX_EXTENSIONS[path.extname(config.searchPath)],
-      );
-
+      isJSX = Boolean(compilerOptions?.jsx || pragma);
       decorators = compilerOptions?.experimentalDecorators;
     }
 
@@ -359,6 +354,15 @@ export default (new Transformer({
 
     let supportsModuleWorkers =
       asset.env.shouldScopeHoist && asset.env.supports('worker-module', true);
+    let isJSX = Boolean(config?.isJSX);
+    if (asset.isSource) {
+      if (asset.type === 'ts') {
+        isJSX = false;
+      } else if (!isJSX) {
+        isJSX = Boolean(JSX_EXTENSIONS[asset.type]);
+      }
+    }
+
     let {
       dependencies,
       code: compiledCode,
@@ -380,7 +384,7 @@ export default (new Transformer({
       is_worker: asset.env.isWorker(),
       env,
       is_type_script: asset.type === 'ts' || asset.type === 'tsx',
-      is_jsx: Boolean(config?.isJSX),
+      is_jsx: isJSX,
       jsx_pragma: config?.pragma,
       jsx_pragma_frag: config?.pragmaFrag,
       automatic_jsx_runtime: Boolean(config?.automaticJSXRuntime),