Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.ts with OctokitOptions export #646

Merged
merged 4 commits into from Jan 20, 2024
Merged

Update index.ts with OctokitOptions export #646

merged 4 commits into from Jan 20, 2024

Conversation

mcgear
Copy link
Contributor

@mcgear mcgear commented Dec 18, 2023

Resolves #645

Before the change?

OctokitOptions is not currently exported for use in strong typing solutions.

After the change?

OctokitOptions is exported from index.ts

Pull request checklist

N/A

Does this introduce a breaking change?

No breaking changes

Please see our docs on breaking changes to help!

  • Yes
  • [x ] No

@github-actions GitHub Actions
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@mcgear mcgear mentioned this pull request Dec 18, 2023
Closed
1 task
@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Dec 18, 2023
wolfy1339
wolfy1339 reviewed Dec 18, 2023
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@nickfloyd
Copy link
Contributor

Hey @mcgear Let us know what you think about @wolfy1339's suggestion and once confirmed we can get this merged in and released. Thanks for the commits here ❤️ .

@mcgear @wolfy1339
Update src/index.ts
6bb854b 
Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
@mcgear
Copy link
Contributor Author

mcgear commented Jan 19, 2024

Sorry about that, i put that in.

@wolfy1339
Copy link
Member

Can you also merge the latest changes from the main branch?

@mcgear
Copy link
Contributor Author

mcgear commented Jan 20, 2024

Done

@wolfy1339 wolfy1339 merged commit d41fe5d into octokit:main Jan 20, 2024
7 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfy1339 wolfy1339 wolfy1339 approved these changes

Assignees
No one assigned
Labels
released on @5.x released Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: OctokitOptions declared locally but not exported
3 participants
@mcgear @nickfloyd @wolfy1339