Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): deprecate mode option #8044

Merged
merged 6 commits into from Sep 9, 2020
Merged

chore(config): deprecate mode option #8044

merged 6 commits into from Sep 9, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 9, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Deprecate mode option in favor of ssr to keep consistent with docs. We have to also update cna template

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 changed the title chore: deprecate mode option chore(config): deprecate mode option Sep 9, 2020
@pi0 pi0 requested a review from a team September 9, 2020 10:55
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2020

Codecov Report

Merging #8044 into dev will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #8044      +/-   ##
==========================================
+ Coverage   68.97%   68.98%   +0.01%     
==========================================
  Files          91       91              
  Lines        3842     3847       +5     
  Branches     1045     1047       +2     
==========================================
+ Hits         2650     2654       +4     
- Misses        968      969       +1     
  Partials      224      224              
Flag Coverage Δ
#unittests 68.98% <80.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/config/src/config/_common.js 100.00% <ø> (ø)
packages/config/src/options.js 94.56% <80.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 757d5d4...32c1a19. Read the comment docs.

Atinux
Atinux previously approved these changes Sep 9, 2020
clarkdo
clarkdo previously approved these changes Sep 9, 2020
@pi0 pi0 merged commit d864b2b into dev Sep 9, 2020
@pi0 pi0 deleted the chore/deprecate-mode branch September 9, 2020 14:39
@pi0 pi0 mentioned this pull request Sep 9, 2020
@weotch
Copy link

weotch commented Sep 28, 2020

I'm getting mode option is deprecated message when running yarn dev --spa, is that intentional?

@pi0
Copy link
Member Author

pi0 commented Sep 30, 2020

@weotch Actually not. I created #8133 to track bug

@clarkdo
Copy link
Member

clarkdo commented Sep 30, 2020

@pi0 I'll take a look at this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants