Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): support chaining functions with promise #8038

Merged
merged 2 commits into from Sep 9, 2020
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 9, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixing #8037

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2020

Codecov Report

Merging #8038 into dev will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #8038      +/-   ##
==========================================
+ Coverage   68.87%   68.98%   +0.10%     
==========================================
  Files          91       91              
  Lines        3849     3840       -9     
  Branches     1044     1044              
==========================================
- Hits         2651     2649       -2     
+ Misses        971      967       -4     
+ Partials      227      224       -3     
Flag Coverage Δ
#unittests 68.98% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/task.js 100.00% <100.00%> (ø)
packages/config/src/load.js 75.28% <0.00%> (-2.63%) ⬇️
packages/webpack/src/config/base.js 64.45% <0.00%> (-0.18%) ⬇️
packages/webpack/src/config/client.js 69.44% <0.00%> (+6.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bafd77...08c302f. Read the comment docs.

@pi0 pi0 changed the title fix(utils): support chaining with promise fix(utils): support chaining functions with promise Sep 9, 2020
@pi0 pi0 merged commit 7961e53 into dev Sep 9, 2020
@pi0 pi0 deleted the fix/chain-promise branch September 9, 2020 09:22
This was referenced Sep 9, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants