Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): missing layout in error page with splittedChunks.layout #8016

Merged
merged 5 commits into from Sep 9, 2020

Conversation

Kolobok12309
Copy link
Contributor

@Kolobok12309 Kolobok12309 commented Sep 3, 2020

Fix error layout for splittedChunks: { layouts: true }

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix loading of error layout
Breaking change ONLY because context.error now although change layout not only in asyncData/etc, for example this change layout

methods: {
  onClick() {
    this.$nuxt.context.error(new Error('Test error'))
  }
}

Resolve: #7654
Resolve: #7658
Resolve: #7014

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020

Codecov Report

Merging #8016 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8016   +/-   ##
=======================================
  Coverage   68.97%   68.97%           
=======================================
  Files          91       91           
  Lines        3842     3842           
  Branches     1045     1045           
=======================================
  Hits         2650     2650           
  Misses        968      968           
  Partials      224      224           
Flag Coverage Δ
#unittests 68.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e3532e...6b6a35a. Read the comment docs.

@clarkdo clarkdo changed the title Fix/error splitted layout fix(vue-app): missing layout in error page with splittedChunks.layout Sep 8, 2020
clarkdo
clarkdo previously approved these changes Sep 8, 2020
@clarkdo clarkdo requested a review from pi0 September 8, 2020 09:27
pi0
pi0 previously approved these changes Sep 9, 2020
@pi0 pi0 requested a review from Atinux September 9, 2020 08:55
Atinux
Atinux previously approved these changes Sep 9, 2020
@pi0 pi0 dismissed stale reviews from Atinux, clarkdo, and themself via 6b6a35a September 9, 2020 10:28
@pi0
Copy link
Member

pi0 commented Sep 9, 2020

Thanks for PR @Kolobok12309 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error page custom layout not being always respected and loaded. Splitted layout with error page
6 participants