New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): avoid recursion when interpolating env #8014
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #8014 +/- ##
==========================================
- Coverage 68.87% 68.82% -0.06%
==========================================
Files 91 91
Lines 3849 3852 +3
Branches 1044 1046 +2
==========================================
Hits 2651 2651
- Misses 971 973 +2
- Partials 227 228 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about giving a warning message here?
@clarkdo Making sense. I also improved logic to early stop to avoid duplicate values: |
Types of changes
Description
originally reported by @hartmut-co-uk in discord following config makes maximum call stack error:
It is also reproducible with dotenv-expand itself when using variable as value. Since we are using forked version there is this PR but have to also fix for upstream.
Checklist: