Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert production js chunk names #8012

Merged
merged 6 commits into from Sep 9, 2020
Merged

fix: revert production js chunk names #8012

merged 6 commits into from Sep 9, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 3, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

We started using human readable names as part of production chunks (#7463) but then multiple regressions reported (some history at #7808) and also currently #7994 and #7882 are open.

So even tough previous regressions resolved and current open issues can be fixed, it seems not worth keep supporting it for nuxt@2. Will continue this for nuxt@3 with more tests (and probably only for limited async and initial chunks not all)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested a review from a team September 3, 2020 11:08
@pi0 pi0 changed the title fix: revert production chunk names for production fix: revert production js chunk names Sep 3, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020

Codecov Report

Merging #8012 into dev will increase coverage by 0.14%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #8012      +/-   ##
==========================================
+ Coverage   68.87%   69.02%   +0.14%     
==========================================
  Files          91       91              
  Lines        3849     3835      -14     
  Branches     1043     1039       -4     
==========================================
- Hits         2651     2647       -4     
+ Misses        972      965       -7     
+ Partials      226      223       -3     
Flag Coverage Δ
#unittests 69.02% <75.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/webpack/src/config/client.js 69.44% <ø> (+6.94%) ⬆️
packages/webpack/src/config/base.js 64.45% <50.00%> (-0.18%) ⬇️
packages/config/src/config/build.js 100.00% <100.00%> (ø)
packages/config/src/load.js 77.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 866b4dd...3c3f042. Read the comment docs.

clarkdo
clarkdo previously approved these changes Sep 3, 2020
@pi0 pi0 merged commit a3d8364 into dev Sep 9, 2020
This was referenced Sep 9, 2020
@pi0 pi0 deleted the fix/chunknames branch September 9, 2020 09:28
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants