Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): no module scripts in spa modern client mode #7967

Merged
merged 1 commit into from Aug 25, 2020
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Aug 25, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Issue: #7562 (comment)

modern template will wait for legacy template until alterAssetTagGroups now, but this may still have racing condition if legacy build emits template file after modern build, this pr is changing to let modern template wait until legacy template is emtited.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from pi0 August 25, 2020 19:16
@pi0 pi0 changed the title feat(webpack): no module scripts in spa modern client mode fix(webpack): no module scripts in spa modern client mode Aug 25, 2020
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

Merging #7967 into dev will increase coverage by 0.05%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7967      +/-   ##
==========================================
+ Coverage   68.92%   68.98%   +0.05%     
==========================================
  Files          91       91              
  Lines        3846     3843       -3     
  Branches     1041     1041              
==========================================
  Hits         2651     2651              
+ Misses        971      968       -3     
  Partials      224      224              
Flag Coverage Δ
#unittests 68.98% <10.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/webpack/src/plugins/vue/modern.js 3.70% <10.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9d759...53c37d9. Read the comment docs.

@pi0 pi0 merged commit 11646ba into dev Aug 25, 2020
@pi0 pi0 deleted the modern-template branch August 25, 2020 19:26
@pi0 pi0 mentioned this pull request Aug 26, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants