Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module): protect clearRequireCache against infinite recursion #7966

Merged
merged 3 commits into from Aug 26, 2020

Conversation

netkin-paris
Copy link

Types of changes

  • [x ] Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This is a very small change, fixing a recently introduced bug when using nuxt-ts : recursive function clearRequireCache was not protected against infinite recursion when dealing with code containing circular reference between modules.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2020

Codecov Report

Merging #7966 into dev will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7966      +/-   ##
==========================================
+ Coverage   68.92%   68.94%   +0.01%     
==========================================
  Files          91       91              
  Lines        3846     3845       -1     
  Branches     1041     1042       +1     
==========================================
  Hits         2651     2651              
+ Misses        971      969       -2     
- Partials      224      225       +1     
Flag Coverage Δ
#unittests 68.94% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/cjs.js 69.69% <0.00%> (ø)
packages/cli/src/utils/generate.js 0.00% <0.00%> (ø)
packages/webpack/src/plugins/vue/modern.js 3.70% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72d03a...8662c32. Read the comment docs.

@pi0 pi0 changed the title Fix cjs.js against circular file deps infinite recursion fix(module): protect clearRequireCache against infinite recursion Aug 25, 2020
@pi0 pi0 mentioned this pull request Aug 25, 2020
7 tasks
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️ Also confirmed by @farnabaz to be working

@pi0 pi0 merged commit 7cecbcc into nuxt:dev Aug 26, 2020
@pi0 pi0 mentioned this pull request Aug 26, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants