Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add avif format as image #7961

Merged
merged 2 commits into from Aug 25, 2020
Merged

chore: add avif format as image #7961

merged 2 commits into from Aug 25, 2020

Conversation

manniL
Copy link
Member

@manniL manniL commented Aug 24, 2020

AVIF, a new image compression format, will be supported in the next Chrome version and is supported behind a flag in FireFox (source). We should add it to our default webpack config so users can utilize the format!

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

Codecov Report

Merging #7961 into dev will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7961   +/-   ##
=======================================
  Coverage   68.92%   68.92%           
=======================================
  Files          91       91           
  Lines        3846     3846           
  Branches     1041     1041           
=======================================
  Hits         2651     2651           
  Misses        971      971           
  Partials      224      224           
Flag Coverage Δ
#unittests 68.92% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/spa.js 0.00% <0.00%> (ø)
packages/webpack/src/config/base.js 64.63% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9d759...6c0a3e5. Read the comment docs.

@pi0 pi0 changed the title feat(webpack): add avif support chore: add avif format as image Aug 25, 2020
@phartikainen
Copy link

Took me....a loooongggggggg time to figure out why my webpack config would not work after 2.14.3.

@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants