Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-renderer): add crossorigin for styles #7954

Merged
merged 7 commits into from Aug 26, 2020
Merged

Conversation

perljusback
Copy link

Adding renderStyles to ssr renderer to enable crossorigin on styles

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Copied the logic from renderScripts for crossorigin and created a similar one for renderStyles t
Resolves: #7953

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Adding renderStyles to ssr.js to enable crossorigin on preload styles
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #7954 into dev will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7954      +/-   ##
==========================================
- Coverage   68.91%   68.87%   -0.04%     
==========================================
  Files          91       91              
  Lines        3847     3849       +2     
  Branches     1042     1043       +1     
==========================================
  Hits         2651     2651              
- Misses        971      972       +1     
- Partials      225      226       +1     
Flag Coverage Δ
#unittests 68.87% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/ssr.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb8a65...aff7d76. Read the comment docs.

@pi0 pi0 requested a review from clarkdo August 21, 2020 10:52
@clarkdo clarkdo requested a review from pi0 August 26, 2020 11:30
pi0
pi0 previously approved these changes Aug 26, 2020
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all 💚

@pi0 pi0 changed the title fix: Added ability for styles to get crossorigin if set fix(vue-renderer): added ability for styles to get crossorigin if set Aug 26, 2020
@pi0 pi0 changed the title fix(vue-renderer): added ability for styles to get crossorigin if set fix(vue-renderer): add crossorigin for styles Aug 26, 2020
@clarkdo clarkdo merged commit 2f76702 into nuxt:dev Aug 26, 2020
@pi0 pi0 mentioned this pull request Aug 26, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crossorigin on styles not getting set
5 participants