fix(vue-app): var names shadowing in chrome debugger #7939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kapcash
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #7939 +/- ##
=======================================
Coverage 68.92% 68.92%
=======================================
Files 91 91
Lines 3846 3846
Branches 1041 1041
=======================================
Hits 2651 2651
Misses 971 971
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Kapcash
changed the title
clarkdo
reviewed
Aug 25, 2020
packages/vue-app/template/store.js
Outdated
| @@ -94,10 +94,10 @@ function resolveStoreModules (moduleData, filename) { | |||
| // If src is a known Vuex property | |||
| if (VUEX_PROPERTIES.includes(moduleName)) { | |||
| const property = moduleName | |||
| const storeModule = getStoreModule(store, namespaces, { isProperty: true }) | |||
| const moduleStore = getStoreModule(store, namespaces, { isProperty: true }) | |||
There was a problem hiding this comment.
What about propertyStoreModule ?
There was a problem hiding this comment.
Why not! It's better actually haha
Gonna change that soon
pi0
changed the title
pi0
approved these changes
Aug 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7731 :)
Just renamed a variable in a small block so that another variable in the parent block don't shadow eachother in the Chrome debugger.
Types of changes
Checklist: