Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter 'fail-on-error' does not work in full static mode. #7947

Closed
sho-zy opened this issue Aug 20, 2020 · 2 comments · Fixed by #7948
Closed

Parameter 'fail-on-error' does not work in full static mode. #7947

sho-zy opened this issue Aug 20, 2020 · 2 comments · Fixed by #7948
Labels
2.x pending triage

Comments

@sho-zy
Copy link

sho-zy commented Aug 20, 2020

Versions

  • nuxt: 2.14.3
  • node: v12.13.1

Reproduction

https://github.com/sho-zy/fail-in-full-static

Steps to reproduce

  1. Run $ yarn generate --fail-on-error

What is Expected?

Command failed with exit code 1.

What is actually happening?

Command completed normally.
2020-08-20 21 11 19
@sho-zy sho-zy mentioned this issue Aug 20, 2020
Merged
7 tasks
@pi0 pi0 closed this as completed in #7948 Aug 25, 2020
@pi0 pi0 mentioned this issue Aug 26, 2020
Merged
@pi0
Copy link
Member

pi0 commented Aug 27, 2020

fixed by v2.14.4

@andre-brdoch
Copy link

hey, if an error is thrown in fetch, the build will still succeed: #7742

atinux pointed out that it might take some time to fix, but I thought it would be relevant to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x pending triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): handle error in full static mode with --fail-on-error sho-zy/nuxt.js
4 participants
@pi0 @sho-zy @danielroe @andre-brdoch