fix: tag codeowner for all release ci runs that are not success (#282)

npm · Feb 8, 2023 · 241dbf2 · 241dbf2
1 parent dc73ffe
commit 241dbf2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -368,7 +368,6 @@ jobs:
       - name: Get Needs Result
         id: needs-result
         run: |
-          result=""
           if [[ "${{ contains(needs.*.result, 'failure') }}" == "true" ]]; then
             result="x"
           elif [[ "${{ contains(needs.*.result, 'cancelled') }}" == "true" ]]; then
@@ -397,7 +396,8 @@ jobs:
             if (updateComment) {
               console.log('Found comment to update:', JSON.stringify(updateComment, null, 2))
               let body = updateComment.body.replace(/Workflow run: :[a-z_]+:/, `Workflow run: :${RESULT}:`)
-              if (RESULT === 'x') {
+              const tagCodeowner = RESULT !== 'white_check_mark'
+              if (tagCodeowner) {
                 body += `\n\n:rotating_light:`
                 body += ` @npm/cli-team: The post-release workflow failed for this release.`
                 body += ` Manual steps may need to be taken after examining the workflow output`

diff --git a/lib/content/release.yml b/lib/content/release.yml
@@ -172,7 +172,6 @@ jobs:
       - name: Get Needs Result
         id: needs-result
         run: |
-          result=""
           if [[ "$\{{ contains(needs.*.result, 'failure') }}" == "true" ]]; then
             result="x"
           elif [[ "$\{{ contains(needs.*.result, 'cancelled') }}" == "true" ]]; then
@@ -201,7 +200,8 @@ jobs:
             if (updateComment) {
               console.log('Found comment to update:', JSON.stringify(updateComment, null, 2))
               let body = updateComment.body.replace(/Workflow run: :[a-z_]+:/, `Workflow run: :${RESULT}:`)
-              if (RESULT === 'x') {
+              const tagCodeowner = RESULT !== 'white_check_mark'
+              if (tagCodeowner) {
                 body += `\n\n:rotating_light:`
                 body += ` {{ codeowner }}: The post-release workflow failed for this release.`
                 body += ` Manual steps may need to be taken after examining the workflow output`

diff --git a/tap-snapshots/test/apply/source-snapshots.js.test.cjs b/tap-snapshots/test/apply/source-snapshots.js.test.cjs
@@ -1122,7 +1122,6 @@ jobs:
       - name: Get Needs Result
         id: needs-result
         run: |
-          result=""
           if [[ "\${{ contains(needs.*.result, 'failure') }}" == "true" ]]; then
             result="x"
           elif [[ "\${{ contains(needs.*.result, 'cancelled') }}" == "true" ]]; then
@@ -1151,7 +1150,8 @@ jobs:
             if (updateComment) {
               console.log('Found comment to update:', JSON.stringify(updateComment, null, 2))
               let body = updateComment.body.replace(/Workflow run: :[a-z_]+:/, \`Workflow run: :\${RESULT}:\`)
-              if (RESULT === 'x') {
+              const tagCodeowner = RESULT !== 'white_check_mark'
+              if (tagCodeowner) {
                 body += \`/n/n:rotating_light:\`
                 body += \` @npm/cli-team: The post-release workflow failed for this release.\`
                 body += \` Manual steps may need to be taken after examining the workflow output\`
@@ -2707,7 +2707,6 @@ jobs:
       - name: Get Needs Result
         id: needs-result
         run: |
-          result=""
           if [[ "\${{ contains(needs.*.result, 'failure') }}" == "true" ]]; then
             result="x"
           elif [[ "\${{ contains(needs.*.result, 'cancelled') }}" == "true" ]]; then
@@ -2736,7 +2735,8 @@ jobs:
             if (updateComment) {
               console.log('Found comment to update:', JSON.stringify(updateComment, null, 2))
               let body = updateComment.body.replace(/Workflow run: :[a-z_]+:/, \`Workflow run: :\${RESULT}:\`)
-              if (RESULT === 'x') {
+              const tagCodeowner = RESULT !== 'white_check_mark'
+              if (tagCodeowner) {
                 body += \`/n/n:rotating_light:\`
                 body += \` @npm/cli-team: The post-release workflow failed for this release.\`
                 body += \` Manual steps may need to be taken after examining the workflow output\`
@@ -4135,7 +4135,6 @@ jobs:
       - name: Get Needs Result
         id: needs-result
         run: |
-          result=""
           if [[ "\${{ contains(needs.*.result, 'failure') }}" == "true" ]]; then
             result="x"
           elif [[ "\${{ contains(needs.*.result, 'cancelled') }}" == "true" ]]; then
@@ -4164,7 +4163,8 @@ jobs:
             if (updateComment) {
               console.log('Found comment to update:', JSON.stringify(updateComment, null, 2))
               let body = updateComment.body.replace(/Workflow run: :[a-z_]+:/, \`Workflow run: :\${RESULT}:\`)
-              if (RESULT === 'x') {
+              const tagCodeowner = RESULT !== 'white_check_mark'
+              if (tagCodeowner) {
                 body += \`/n/n:rotating_light:\`
                 body += \` @npm/cli-team: The post-release workflow failed for this release.\`
                 body += \` Manual steps may need to be taken after examining the workflow output\`