This repository has been archived by the owner on May 4, 2024. It is now read-only.
fix: use jsonClone to fix cache layer #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any way to reliably test this? |
|
Sure. I'll add a test a bit later |
antongolub
force-pushed
the
fix-cache-layer
branch
from
678803a
to
f3799db
Compare
wraithgar
changed the title
wraithgar
approved these changes
May 3, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
Some objects may get corrupted during caching
UPD Finally figured out that the cache does not work at all
Actual impl
52ad4c5
Expected